Fix toast crashes #1154
Merged
Fix toast crashes #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutmanz
added
bug
ui/ux
|
How do I reproduce this in |
BrandonPacewic
approved these changes
Jun 24, 2025
There was a problem hiding this comment.
How do I reproduce this in
devsince I don't see a problem when I run the test toasts from the debug panel
@Dhruv-0-Arora I believe this is just to fix the prop name collision with type.
Seems reasonable to me 🍞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dev branch was previously exhibiting intermittent page crashing with toasts (
typewas undefined). I don't see a definitive cause but I imagine it's related to the use oftypeas the parameter name. Renaming seems to have resolved the issue.