Improve Preferences Interface [AARD-1906]
#1150
Conversation
BrandonPacewic
added
the
ui/ux
There was a problem hiding this comment.
This might be something to merge after #1070 since it will cause a lot of merge conflicts if we merge it before 😓
There was a problem hiding this comment.
Still some persistent issues here, will take over this PR since @rutmanz is out for the week.
There was a problem hiding this comment.
Double check and make sure that the changes made while the panel is open get reverted upon pressing cancel. For me this manifested in disabling/enabling the scoreboard, pressing cancel, and having the scoreboard not revert to whatever previous state it was in (and should still be in).
There was a problem hiding this comment.
Awesome looks good.
Also replaces the type assertions in the preference system with more robust generics for type checking
As I briefly mentioned before, in the future please include small refactors like this in separate PRs. I don't want to discourage these types of changes at all (in fact these are my favorite types to review, so please do more of them) just separate them out of feature pushes.
Nice work ⚙️
Description
Propagates preference changes instantly instead of waiting for the panel to close. Also replaces the type assertions in the preference system with more robust generics for type checking
AARD-1906