-
Notifications
You must be signed in to change notification settings - Fork 60
Main Menu Screen [AARD-1878]
#1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main Menu Screen [AARD-1878]
#1128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it might be better to use the toast system for the multiplayer alert (I know we are probably going to be changing it rather soon). Additionally some weird behaviour happens when you click outside the main menu modal when it first pops up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket specified that this menu should precede loading the scene, presumably so that multiplayer could have an entirely different initialization. We could load it anyway or do something else with the background. I agree it's not great to have blank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Sounds like we have a UI refactor coming so we are probably going to end up changing some stuff here.
Two comments I had:
- We should be hiding the side panel since it doesn't do anything till you actually launch the sim.
- Scoreboard should probably also be hidden.
Like I mentioned, UI refactor coming so we are probably going to change this anyways. Run the auto formatter and we can mark this as done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes for end of summer UI polish:
- Should consider the difference between launching into the sim and displaying a main menu.
- For parallel with fusion some form of instant sim access seems better.
- Should have a UX conversation about what we want the final user flow on launch to be.
Looks good to me!
Co-authored-by: Dhruv Arora <a_dhruv@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I agree about hiding the other UI elements but that can happen after the UI refactor.
[AARD-1878]
Description
Adds a main menu that precedes world initialization and requires a choice of singleplayer or multiplayer.
JIRA Issue