Skip to content

Conversation

rutmanz
Copy link
Member

@rutmanz rutmanz commented Jun 17, 2025

Description

Adds a main menu that precedes world initialization and requires a choice of singleplayer or multiplayer.

JIRA Issue

@rutmanz rutmanz requested review from HunterBarclay and a team as code owners June 17, 2025 19:15
@rutmanz rutmanz requested a review from Dhruv-0-Arora June 17, 2025 19:15
@BrandonPacewic BrandonPacewic self-requested a review June 17, 2025 20:58
@BrandonPacewic BrandonPacewic added the ui/ux Relating to user interface, or in general, user experience label Jun 17, 2025
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it might be better to use the toast system for the multiplayer alert (I know we are probably going to be changing it rather soon). Additionally some weird behaviour happens when you click outside the main menu modal when it first pops up.

@rutmanz rutmanz requested a review from BrandonPacewic June 17, 2025 21:39
Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible for you to render it over the scene instead of a gray frame?

Screenshot 2025-06-17 at 5 27 02 PM

@rutmanz
Copy link
Member Author

rutmanz commented Jun 18, 2025

The ticket specified that this menu should precede loading the scene, presumably so that multiplayer could have an entirely different initialization. We could load it anyway or do something else with the background. I agree it's not great to have blank

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sounds like we have a UI refactor coming so we are probably going to end up changing some stuff here.

Two comments I had:

  1. We should be hiding the side panel since it doesn't do anything till you actually launch the sim.
  2. Scoreboard should probably also be hidden.

Like I mentioned, UI refactor coming so we are probably going to change this anyways. Run the auto formatter and we can mark this as done.

@rutmanz rutmanz requested a review from a team as a code owner June 18, 2025 17:17
@PepperLola PepperLola requested a review from Dhruv-0-Arora June 18, 2025 18:06
@rutmanz rutmanz changed the title Main Menu Screen Main Menu Screen [AARD-1878] Jun 18, 2025
@rutmanz rutmanz changed the title Main Menu Screen [AARD-1878] Main Menu Screen [AARD-1878] Jun 19, 2025
@rutmanz rutmanz changed the title Main Menu Screen [AARD-1878] Main Menu Screen [AARD-1878] Jun 19, 2025
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes for end of summer UI polish:

  • Should consider the difference between launching into the sim and displaying a main menu.
  • For parallel with fusion some form of instant sim access seems better.
  • Should have a UX conversation about what we want the final user flow on launch to be.

Looks good to me!

Co-authored-by: Dhruv Arora <a_dhruv@outlook.com>
@rutmanz rutmanz requested a review from Dhruv-0-Arora June 19, 2025 19:07
Copy link
Member

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I agree about hiding the other UI elements but that can happen after the UI refactor.

@BrandonPacewic BrandonPacewic changed the title Main Menu Screen [AARD-1878] Main Menu Screen [AARD-1878] Jun 19, 2025
@BrandonPacewic BrandonPacewic merged commit db5c0f6 into Autodesk:dev Jun 19, 2025
14 of 15 checks passed
@BrandonPacewic BrandonPacewic mentioned this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants