fix: various small fixes found from new integration testing #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ci: oops typo
vjeeva
force-pushed
the
vjeeva/issue-404
branch
from
63fd51b to
7b7f2ef
Compare
…tegration testing test: oops missed a spot
vjeeva
force-pushed
the
vjeeva/issue-404
branch
from
d07a5df to
ef093df
Compare
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
vjeeva
changed the title
jdcallet
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also upgrades integration testing, addressing #405 and #404.
The integration tests run against 4 sets of DBs now:
Public Schema, Whole DB
Non-Public Schema, Whole DB
Public Schema, Exodus (subset of data)
Non-Public Schema, Exodus (subset of data
It's parallelized by creating 4 DB configs and just running the integration test against all DB pairs.