Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update integration tests to check non-public schemas #403

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

vjeeva
Copy link
Contributor

@vjeeva vjeeva commented Feb 27, 2024

This includes a big refactor on the integration test, to make it modular for multiplexing the workflow against various test cases.

This PR is missing the following, which may be just filed as separate issues:

  • Parallelization of the integration tests - this needs some thought (especially on how to collect all the output in a legible way)
  • Finishing up the Exodus tests - they won't pass in the current state because we do a total dump comparison between the source and destination. Exodus implies that only a subset of data gets migrated, so the test needs to support that.

@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

@vjeeva vjeeva force-pushed the vjeeva/non-public-schemas-integration branch from cbd121f to 2850890 Compare February 27, 2024 00:43
@vjeeva
Copy link
Contributor Author

vjeeva commented Feb 27, 2024

Related to #398 and #397

@vjeeva vjeeva force-pushed the vjeeva/non-public-schemas-integration branch from 2850890 to 6623ece Compare February 27, 2024 15:36
@vjeeva vjeeva force-pushed the vjeeva/non-public-schemas-integration branch from 6623ece to 58d441a Compare February 27, 2024 16:59
@vjeeva vjeeva force-pushed the vjeeva/non-public-schemas-integration branch from 58d441a to ddf3351 Compare February 27, 2024 17:05
@vjeeva
Copy link
Contributor Author

vjeeva commented Feb 27, 2024

#405 #404 were filed to address later.

@vjeeva vjeeva merged commit 3ec6499 into main Feb 27, 2024
11 checks passed
@vjeeva vjeeva deleted the vjeeva/non-public-schemas-integration branch February 27, 2024 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants