Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: local dev container uses local mount for faster testing #391

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

vjeeva
Copy link
Contributor

@vjeeva vjeeva commented Feb 21, 2024

@jdcallet brought this up as a good feature to have.

This change allows for usage of make local-dev to not require you to clean up your local environment to alter your code and build a new testable copy of belt.

You can now instead run make local-dev to spin up the SRC/DST DB containers, and your belt container instead builds belt based on the local code you have on your laptop as a volume. Therefore, when you make a code change, you can just run pip install -e . to update your test container's belt binary instead of rebuilding everything.

Note: it is indeed redundant to volume while the container is built with the build-time copy of the pgbelt code. I decided against removing that local copy in the Dockerfile to keep our CI steps from not needing to install poetry dependencies on each CI step (see the black and flake8 steps - they are run using that built container).

@vjeeva vjeeva requested a review from jdcallet February 21, 2024 20:55
@vjeeva vjeeva merged commit 42318ef into main Feb 21, 2024
11 checks passed
@vjeeva vjeeva deleted the vjeeva/faster-local-dev branch February 21, 2024 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants