Support empty data repositories #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsxschneider
previously approved these changes
Apr 23, 2018
updater/schema.py
Outdated
| metaFilePath = os.path.join(dataDirectory, "meta.tsv") | ||
|
|
||
| # If the data repository is empty, no schema compatibility check is necessary | ||
| if not os.path.exists(metaFilePath): |
There was a problem hiding this comment.
Minor nit, you don't check the emptiness of the data repository. You just check if the meta.tsv is not there yet. I think you should either adjust the comment or change the code 😉
There was a problem hiding this comment.
I’d rather adjust the code, because it wouldn’t make sense to check the data repository in this case. I agree that the comment could have been more concise. I’ll adjust this.
pluehne
force-pushed
the
patrick/fix-missing-meta.tsv
branch
from
aaad876 to
7312292
Compare
By accident, newly created data repositories didn’t work with the updater. The reason is that the updater checked the data schema version but failed, because no meta.tsv file (which contains the data schema version) was present. This adds a check that, if the meta.tsv file is not yet present, simply succeeds with the update, through which the data repository is populated with an up-to-date schema anyway.
pluehne
force-pushed
the
patrick/fix-missing-meta.tsv
branch
from
7312292 to
4d5a807
Compare
|
@larsxschneider: I addressed your suggestion, please review again 🙂. |
larsxschneider
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accident, newly created data repositories didn’t work with the updater. The reason is that the updater checked the data schema version but failed, because no
meta.tsvfile (which contains the data schema version) was present.This adds a check that, if the
meta.tsvfile is not yet present, simply succeeds with the update, through which the data repository is populated with an up-to-date schema anyway.In contrast to #146, this allows users to get started with an empty repository instead of having to create a
meta.tsvmanually and reading through some more documentation.Closes #145.