Skip to content

Merging fix-7.0.0 to master #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 16, 2021
Merged

Merging fix-7.0.0 to master #927

merged 13 commits into from
Nov 16, 2021

Conversation

sirpalee
Copy link
Contributor

Changes proposed in this pull request

  • Using GetVolumeShader if native rprim is volume.:
  • Hide all geometries under the PointInstancer hierarchy, as usdview and Hydra do. In order to do that in the different traversal modes we have (single-threaded, multi-threaded with a fix thread count, and default "dispatcher" mode), I've had to add a bit of code in the different thread context classes, in a similar way to what was done previously for the primvars stack of each primvar.
  • For each instance, the visibility is the one of the corresponding prototype. So for each proto, we compute its visibility to apply it to the ginstance. This way by just hiding one of the prototypes, we can hide all of its instances.
  • Update tests for Arnold 7.
  • Just as we were doing for the default reflection shader, we're now ensuring we don't write out the default color manager node.
  • As it's being done in the render delegate, the procedural now remaps the curves primvars in certain interpolations and curve bases. This was already done for the curves width, so we had to extend it to other primvars.
  • The function UsdArnoldPrimReader::ReadPrimvars already had an optional argument MeshOrientation to eventually modify some primvars indexes for polymeshes. Here we needed a similar argument to remap the curves so instead of adding yet another argument, I've replaced the mesh orientation by a more generic PrimvarsRemapper that is specialized in both the mesh and the curves code to remap the primvars accordingly.

Issues fixed in this pull request
Fixes #915
Fixes #458
Fixes #904
Fixes #922
Fixes #924
Fixes #921
Fixes #854

sirpalee and others added 13 commits September 16, 2021 20:53
@sirpalee
Fixing testsuite issues using 21.02+ and supporting new and old light…
b151a38 
… parameter naming conventions. (#881)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions.

Fixes #880
Fixes #772
@sebastienblor
Only call AiBegin/AiEnd in the delegate if no arnold session is active …
ab354b0 
…#884 (#885)
@sirpalee
Support render tags in the render delegate. (#883)
6ed1247 
* Checking for render tags.
* Tracking render tags for shapes.
* Improving render tag tracking.
* Interrupt before disabling nodes.
* Renaming render tag handling functions and moving the core logic to a separate function.
* Tracking the point instancer's render tag.

Fixes #843
@sirpalee
Improving conversions between integer types. (#889)
82bffbc 
* Setting unsigned int parameters from int. (#887)

* Adding more tests and conversions. (#887)
@sirpalee
Passing render session to AiDeviceAutoSelect. (#903)
93fb345 
Fixes #902
@sirpalee
Avoid calling AiRenderBegin when render is already running. (#901)
89a9fce 
Fixes #900
@sirpalee
Fixing the use of AI_TYPE_INT AOVs and removing a warning when settin…
cd85653 
…g blend_opacity. (#908)

Fixes #905
@sirpalee
Setting the returned version to default in the Sdr plugin. (#907)
5d7fa0d 
Fixes #906
@sirpalee
Using GetVolumeShader if native rprim is volume. (#920)
1e10b89 
Fixes #915
@sebastienblor @sirpalee
Fix pointInstancer and prototypes visibilities (#916)
57d0d64 
* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881) (#882)

Fixes #880
Fixes #772

* Updating master with changes from the fix branch (#886)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions.

Fixes #880
Fixes #772

* Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885)

* Support render tags in the render delegate. (#883)

* Checking for render tags.
* Tracking render tags for shapes.
* Improving render tag tracking.
* Interrupt before disabling nodes.
* Renaming render tag handling functions and moving the core logic to a separate function.
* Tracking the point instancer's render tag.

Fixes #843

Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com>

* Merging fix branch to master. (#894)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions.

Fixes #880
Fixes #772

* Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885)

* Support render tags in the render delegate. (#883)

* Checking for render tags.
* Tracking render tags for shapes.
* Improving render tag tracking.
* Interrupt before disabling nodes.
* Renaming render tag handling functions and moving the core logic to a separate function.
* Tracking the point instancer's render tag.

Fixes #843

* Improving conversions between integer types. (#889)

* Setting unsigned int parameters from int. (#887)

* Adding more tests and conversions. (#887)

Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com>

* Merging fix-7.0.0 to master (#909)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions. (#881)

* Fixing testsuite issues using 21.02+ and supporting new and old light parameter naming conventions.

Fixes #880
Fixes #772

* Only call AiBegin/AiEnd in the delegate if no arnold session is active #884 (#885)

* Support render tags in the render delegate. (#883)

* Checking for render tags.
* Tracking render tags for shapes.
* Improving render tag tracking.
* Interrupt before disabling nodes.
* Renaming render tag handling functions and moving the core logic to a separate function.
* Tracking the point instancer's render tag.

Fixes #843

* Improving conversions between integer types. (#889)

* Setting unsigned int parameters from int. (#887)

* Adding more tests and conversions. (#887)

* Passing render session to AiDeviceAutoSelect. (#903)

Fixes #902

* Avoid calling AiRenderBegin when render is already running. (#901)

Fixes #900

* Fixing the use of AI_TYPE_INT AOVs and removing a warning when setting blend_opacity. (#908)

Fixes #905

* Setting the returned version to default in the Sdr plugin. (#907)

Fixes #906

Co-authored-by: Sebastien Blaineau-Ortega <sebastien.blaineau.ortega@autodesk.com>

* Updating changelog and readme for Arnold 7. (#898)

Fixes #897

* Fix pointInstancer and prototypes visibilities #458

* Updating changelog and readme for Arnold 7. (#898)

Fixes #897

* Fix pointInstancer and prototypes visibilities #458

Co-authored-by: Pal Mezei <sirpalee@users.noreply.github.com>
@sirpalee
Update tests for Arnold 7. (#922) (#923)
fbece7c
@sebastienblor
Don't write the default color manager node to usd #924 (#925)
aac3f17
@sebastienblor
Remap curves primvars (#926)
4dd532d 
* Remap curves primvars values #921

* Simplify calls to RemapCurvesVertexPrimvars #921
@sirpalee sirpalee added bug Something isn't working render delegate Related to the Arnold Render Delegate procedural Related to the Arnold Procedural labels Nov 16, 2021
@sirpalee sirpalee self-assigned this Nov 16, 2021
@sirpalee sirpalee merged commit 0dfbbde into master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienblor sebastienblor sebastienblor approved these changes

Assignees

@sirpalee sirpalee

Labels
bug Something isn't working procedural Related to the Arnold Procedural render delegate Related to the Arnold Render Delegate
Projects
None yet
Milestone
No milestone
2 participants
@sirpalee @sebastienblor