Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid updating the main driver matrices in case of camera movement #870

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Avoid updating the main driver matrices in case of camera movement #870

merged 1 commit into from
Aug 13, 2021

Conversation

sirpalee
Copy link
Contributor

Changes proposed in this pull request

  • Avoid updating the main driver matrices in case of camera movement.

Issues fixed in this pull request
Fixes #869

ThiagoIze
ThiagoIze approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@ThiagoIze ThiagoIze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the matrices are not used in node_update, then sidestepping AiNodeSetMatrix by directly modifying the matrices will let arnold know that when just moving the camera no other nodes need a node_update, and so we can do the camera IPR fast path.

@sirpalee sirpalee merged commit cd8cc5d into Autodesk:master Aug 13, 2021
@sirpalee sirpalee self-assigned this Sep 13, 2021
@sirpalee sirpalee deleted the pr/869 branch September 13, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiagoIze ThiagoIze ThiagoIze approved these changes

Assignees

@sirpalee sirpalee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't update the main driver matrices if only the camera moves
2 participants
@sirpalee @ThiagoIze