Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewriting how render buffers and aborted renders are handled. #309

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Rewriting how render buffers and aborted renders are handled. #309

merged 1 commit into from
Mar 30, 2020

Conversation

sirpalee
Copy link
Contributor

Changes proposed in this pull request

  • Replace the render buffer classes.
  • Directly write to render buffers from the driver.
  • Using Float32 buffers for the color.
  • Handling AiRenderAbort and stop Hydra for infinitely converging.

Issues fixed in this pull request
Fixes #8
Fixes #9
Fixes #4

Additional context
Add any other context or screenshots about the pull request here.

@sirpalee sirpalee added bug Something isn't working enhancement New feature or request render delegate Related to the Arnold Render Delegate labels Mar 27, 2020
@sirpalee sirpalee requested a review from sebastienblor March 27, 2020 10:04
@sirpalee sirpalee self-assigned this Mar 27, 2020
@sirpalee sirpalee force-pushed the pr/fix-8 branch 2 times, most recently from fbedc1f to ceb29f5 Compare March 29, 2020 12:35
@sebastienblor sebastienblor merged commit 49afdf3 into Autodesk:master Mar 30, 2020
@sirpalee sirpalee deleted the pr/fix-8 branch April 2, 2020 04:21
sebastienblor pushed a commit that referenced this pull request Apr 7, 2020
@sirpalee
Rewriting how render buffers and aborted renders are handled. (#309)
18b62bc 
Fixes #8
Fixes #9
Fixes #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienblor sebastienblor sebastienblor approved these changes

Assignees

@sirpalee sirpalee

Labels
bug Something isn't working enhancement New feature or request render delegate Related to the Arnold Render Delegate
Projects
None yet
Milestone
No milestone
2 participants
@sirpalee @sebastienblor