Ensure the ArnoldUsd schema is properly generated #2143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
The changes done for #2088 were missing a use case : when the schemas are generated there might not be a "usd" node entry yet (which is the case when arnold-usd is compiled through arnold core). Also, when that happens the usd procedural has not been built as it needs the schemas to be generated first.
Therefore we need to explicitely add the schema ArnoldUsd to the schemas file. This is not ideal as we need to hardcode the usd procedural attributes list. I added a comment in the procedural
node_parameters
function so that every time an attribute is added it's ported to the schemas script.I could have done all this only when the usd node entry is not found, but I think it's better to do it all the time. Otherwise we're using the node entry that was generated in a previous build and that might not have the correct attributes list. So here when we iterate over the node entries I'm always skipping the usd type, and I'm always explicitely adding later on.
Issues fixed in this pull request
Fixes #2088