Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the ArnoldUsd schema is properly generated #2143

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

sebastienblor
Copy link
Collaborator

Changes proposed in this pull request
The changes done for #2088 were missing a use case : when the schemas are generated there might not be a "usd" node entry yet (which is the case when arnold-usd is compiled through arnold core). Also, when that happens the usd procedural has not been built as it needs the schemas to be generated first.
Therefore we need to explicitely add the schema ArnoldUsd to the schemas file. This is not ideal as we need to hardcode the usd procedural attributes list. I added a comment in the procedural node_parameters function so that every time an attribute is added it's ported to the schemas script.

I could have done all this only when the usd node entry is not found, but I think it's better to do it all the time. Otherwise we're using the node entry that was generated in a previous build and that might not have the correct attributes list. So here when we iterate over the node entries I'm always skipping the usd type, and I'm always explicitely adding later on.

Issues fixed in this pull request
Fixes #2088

@cpichard
Copy link
Collaborator

this could also fix #1764

@sebastienblor sebastienblor merged commit 45c2b98 into Autodesk:master Nov 13, 2024
9 checks passed
@sebastienblor sebastienblor deleted the fix_usd_schema branch November 13, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated schemas
2 participants