Wrong transform when an instanceable prim is not xformable #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
For instanceable primitives that get rendered as an arnold ginstance node, we were only reading the matrix if the instanceable primitive was xformable. This is not correct, as this primitive can have parents that are xforms and which would require to read the matrix.
While doing the fix, I noticed that there was some deprecated code, with an AtArray protoMatrix that is always null, and some code testing what to do if it's non-null.
Added test_2131 with that use case
Issues fixed in this pull request
Fixes #2131