Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use SdfPathVector for aov_shaders #1322

Merged
merged 3 commits into from
Oct 19, 2022
Merged

use SdfPathVector for aov_shaders #1322

merged 3 commits into from
Oct 19, 2022

Conversation

cpichard
Copy link
Collaborator

Changes proposed in this pull request

  • aov_shaders primvar stores paths as a string. With this change, we can now add multiple paths separated by space. Internally they are stored as SdfPathVector.

Issues fixed in this pull request
Fixes #1321

jhodgson
jhodgson previously approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@jhodgson jhodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good for the delegate.

@cpichard cpichard requested a review from jhodgson October 14, 2022 16:48
@cpichard cpichard marked this pull request as ready for review October 14, 2022 16:48
@cpichard cpichard self-assigned this Oct 14, 2022
@sebastienblor sebastienblor merged commit d74c750 into Autodesk:master Oct 19, 2022
@cpichard cpichard added enhancement New feature or request render delegate Related to the Arnold Render Delegate procedural Related to the Arnold Procedural labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienblor sebastienblor sebastienblor approved these changes

@jhodgson jhodgson Awaiting requested review from jhodgson

Assignees

@cpichard cpichard

Labels
enhancement New feature or request procedural Related to the Arnold Procedural render delegate Related to the Arnold Render Delegate
Projects
Arnold USD
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow list of AOV ArnoldNodeGraph primitives in RenderSettings
3 participants
@cpichard @jhodgson @sebastienblor