Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect the opacity on the transmission #1252

Merged
merged 10 commits into from
Aug 16, 2022
Merged

connect the opacity on the transmission #1252

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
16b42fd
connect the opacity on the transmission
cpichard Aug 9, 2022
764c678
remove useless cout
cpichard Aug 9, 2022
97bec64
add constant string "transmission"
cpichard Aug 9, 2022
acb1bc0
add a substract node to convert opacity to transmission in the proced…
cpichard Aug 16, 2022
a914904
add testsuite for issue #1204
cpichard Aug 16, 2022
58a5c89
remap opacity after converting it
cpichard Aug 16, 2022
0bce1c6
fix type mismatch resulting from a GfVec4 multiplication
cpichard Aug 16, 2022
b4f2879
interpret primvarreader_xxx::varname as a string as well as a token
cpichard Aug 16, 2022
93d5505
reorder alphabetically
cpichard Aug 16, 2022
c9048a9
add reference image and bigger donuts
cpichard Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remap opacity after converting it
  • Loading branch information
@cpichard
cpichard committed Aug 16, 2022
commit 58a5c89a52f84ce34f3cee1061730f5ac991e45a
6 changes: 3 additions & 3 deletions render_delegate/node_graph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,13 +150,13 @@ RemapNodeFunc previewSurfaceRemap = [](MaterialEditContext* ctx) {
}

// Float opacity needs to be remapped to 1 - transmission
ctx->RenameParam(str::t_opacity, str::t_transmission);
const auto opacityValue = ctx->GetParam(str::t_opacity);
if (opacityValue.IsHolding<float>()) {
const auto opacity = opacityValue.UncheckedGet<float>();
ctx->SetParam(str::t_transmission, VtValue(1.f - opacity));
ctx->SetParam(str::t_opacity, VtValue(1.f - opacity));
}

ctx->RenameParam(str::t_opacity, str::t_transmission);

ctx->RenameParam(str::t_diffuseColor, str::t_base_color);
ctx->RenameParam(str::t_emissiveColor, str::t_emission_color);
ctx->RenameParam(str::t_roughness, str::t_specular_roughness);
Expand Down