Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR adds support for dataWindowNDC. When set to a non-default value, we use the options region min/max x/y.
Something special as compared to arnold though, is that we don't want the output resolution to change. In other words, the desired resolution must match the window.
This means we need to have
region_max_x - region_min_x = xres - 1
andregion_max_y - region_min_y = yres - 1
.In order to make this work properly, we must then adjust
options.xres options.yres
accordingly.For example, in the case of overscan, we'll set the options xres, yres, to a resolution that is lower than the expected one, but since the window will go beyond [0,0,1,1] the actual amount of pixels will be equal to the desired res.
This also means that if someone sets a very small window, e.g. [0.5, 0.5, 0.6, 0.6], then we might need to increase dramatically xres, yres (x10 in this example).
Issues fixed in this pull request
Fixes #1161