Improve and generalize Hydra dependency graph #1158 #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhodgson
reviewed
May 14, 2022
render_delegate/light.cpp
Outdated
| [&](const SdfPath& p) { lightShaderPath = p; }); | ||
|
|
||
| AtNode *color = nullptr; | ||
| AtNode *shader = nullptr; |
There was a problem hiding this comment.
AtNode *shader = nullptr; is unused
render_delegate/render_delegate.cpp
Outdated
| for (const auto& source : it->second) { | ||
| // for each source referencing the current target | ||
| // we need to remove the target from its list | ||
| auto &sourceIt = _sourceToTargetsMap.find(source); |
There was a problem hiding this comment.
This should be a const reference const auto &sourceIt = _sourceToTargetsMap.find(source);
|
Fixed the build issues in the last commit |
jhodgson
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR does quite a few changes on the previous "tracking" of node graphs. The previous system was a dependency graph, but hardcoded for specific use cases, and not fully reliable. It's important the the list of references & back-references is stored in a centralized place, so that every time something changes, all the lists are properly updated. In this case, the "node graph tracker" which was part of the meshes, was not updated when the render delegate changed its dependencies, and we could end up with crashes or refresh issues when shading nodes were deleted / reconnected / etc...
Here's a list of what this PR changes :
Issues fixed in this pull request
Fixes #1158