Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
When reading the render settings, I'm now reading the attributes
subdiv_dicing_camera
,subdiv_frustum_culling
andsubdiv_frustum_padding
and setting the arnold options node accordingly.The most tricky part is the dicing camera, as we need to point to another AtNode in the scene, that might not exist yet when we're reading it. I'm following a similar system that what is being done for the render camera, or for atmosphere : I'm storing the SdfPath of the dicing cam, and then in RenderPass::_Execute I'm looking for it in the arnold scene based on its name.
Something that wasn't strictly needed in this PR, but that I preferred doing to avoid crashes, is that when we're about to destroy a camera node, we check if it's not referenced in the options, and if so I reset the options attribute
Issues fixed in this pull request
Fixes #1062