Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subdiv dicing camera #1148

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

sebastienblor
Copy link
Collaborator

Changes proposed in this pull request
When reading the render settings, I'm now reading the attributes subdiv_dicing_camera, subdiv_frustum_culling and subdiv_frustum_padding and setting the arnold options node accordingly.

The most tricky part is the dicing camera, as we need to point to another AtNode in the scene, that might not exist yet when we're reading it. I'm following a similar system that what is being done for the render camera, or for atmosphere : I'm storing the SdfPath of the dicing cam, and then in RenderPass::_Execute I'm looking for it in the arnold scene based on its name.

Something that wasn't strictly needed in this PR, but that I preferred doing to avoid crashes, is that when we're about to destroy a camera node, we check if it's not referenced in the options, and if so I reset the options attribute

Issues fixed in this pull request
Fixes #1062

@sebastienblor sebastienblor added enhancement New feature or request render delegate Related to the Arnold Render Delegate labels May 6, 2022
@sebastienblor sebastienblor requested review from kikou, compso and jhodgson May 6, 2022 12:54
@sebastienblor sebastienblor self-assigned this May 6, 2022
@sebastienblor sebastienblor merged commit 6cf0db1 into Autodesk:master May 6, 2022
@sebastienblor sebastienblor deleted the pr/1062 branch May 6, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request render delegate Related to the Arnold Render Delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support subdivision dicing camera
2 participants