Use arnold instancer node in the procedural #1007
Merged
+1,352
−130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we read usd PointInstancer primitives as arnold "instancer" nodes (instead of creating lots of ginstance nodes).
We now set the primvars similarly to what usd does.
I'm adding test_0196 where the primvars are set on the parent instancer, that was already working in the render delegate. All the other tests are working correctly.
I noticed the performance is better than in the previous implementation
Issues fixed in this pull request
Fixes #949
Fixes #938
Fixes #956