Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dataWindowNDC support #1270

Closed
sebastienblor opened this issue Aug 19, 2022 · 1 comment · Fixed by #1271
Closed

Improve dataWindowNDC support #1270

sebastienblor opened this issue Aug 19, 2022 · 1 comment · Fixed by #1271
Assignees
@sebastienblor
Labels
bug Something isn't working procedural Related to the Arnold Procedural render delegate Related to the Arnold Render Delegate user Reported by a user

Comments

@sebastienblor
Copy link
Collaborator

Based on user feedback, the way we're currently supporting dataWindowNDC is not matching what is expected on the user side, regarding the final resolution, data window in the output image, aspect ratio, etc...
This ticket is about handling it differently to match what is done in Husk and other renderers
@sebastienblor sebastienblor added the bug Something isn't working label Aug 19, 2022
@sebastienblor sebastienblor self-assigned this Aug 19, 2022
@sebastienblor
Copy link
Collaborator Author

We also need to fix what happens with deep renders, which are custom render products where arnold provides the image resolution. In this case because of the dataWindowNDC, we don't get the expected resolution (we can have 1 pixel shifts due to calculation precision)

@sebastienblor sebastienblor added render delegate Related to the Arnold Render Delegate procedural Related to the Arnold Procedural user Reported by a user labels Aug 19, 2022
@compso compso moved this to Todo in Arnold USD Aug 19, 2022
@compso compso moved this from Todo to In Progress in Arnold USD Aug 19, 2022
sebastienblor added a commit to sebastienblor/arnold-usd that referenced this issue Aug 19, 2022
@sebastienblor
Improve dataWindowNDC support Autodesk#1270
4968353
@sebastienblor sebastienblor mentioned this issue Aug 19, 2022
Merged
sebastienblor added a commit that referenced this issue Aug 31, 2022
@sebastienblor
Improve dataWindowNDC support #1270 (#1271)
5d15831
Repository owner moved this from In Progress to Done in Arnold USD Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastienblor sebastienblor

Labels
bug Something isn't working procedural Related to the Arnold Procedural render delegate Related to the Arnold Render Delegate user Reported by a user
Projects
Arnold USD
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve dataWindowNDC support sebastienblor/arnold-usd
1 participant
@sebastienblor