This repository was archived by the owner on Jun 13, 2020. It is now read-only.
Merged
Conversation
* Clean up some error handling/response * Do not consider variables being set in a template as unassigned * Allow specifying of icefile prefix
ericfode
approved these changes
Oct 5, 2017
mjuarez
reviewed
Oct 6, 2017
| """Invoked atexit, this removes our tmpdir""" | ||
| if os.path.exists(path) and \ | ||
| os.path.isdir(path): | ||
| rmtree(path) |
There was a problem hiding this comment.
Maybe for a future improvement but implementing something like wipe, srm, or shred to securely delete?
Contributor
Author
There was a problem hiding this comment.
Actually, that could be an 🆗 extension to cryptorito... A subprocess wrapper around srm that is used on supported systems.
mjuarez
reviewed
Oct 6, 2017
|
|
||
| def random_string(length): | ||
| return ''.join(random.choice(string.ascii_uppercase + string.digits) for _ in range(length)) | ||
| return ''.join(random.choice(string.ascii_uppercase + string.digits) for _ in range(length)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
var_files,--extra-vars-file, andaws_file.var_fileandaws_fileare now treated as templates, and rendering has been further standardized throughout aomicryptorito0.6.1thawaction has a new--ignore-missingoption which will cause aomi to not error out, but still emit a warning, when a resource is missing from an icefile that is being thawed. This does not affectfreezeorseed, with those actions the resource must be present.