Out optionalclass is not generating valid code in C++ implementation. #101 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderoster
added a commit
that referenced
this pull request
Jul 21, 2020
alexanderoster
added a commit
that referenced
this pull request
Jul 21, 2020
alexanderoster
added a commit
that referenced
this pull request
Jul 23, 2020
* Added String Out fix for caching string calls * Added Error checking for concurrent string and array out parameters * Stringoutfix (#109) * Added String Out fix for caching string calls * Added Error checking for concurrent string and array out parameters Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Golangarrayin (#110) * Added String Out fix for caching string calls * Added Error checking for concurrent string and array out parameters * support structarray * update readme * Added Golang InArrays Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> Co-authored-by: Quim Muntal Diaz <quim.muntal.diaz@hp.com> * Fixed issue101 (#111) (#112) Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Exchanged auto_ptr through unique_ptr * Stringoutfix (#113) * Added String Out fix for caching string calls * Added Error checking for concurrent string and array out parameters * Exchanged auto_ptr through unique_ptr Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Develop (#115) * Fixed issue101 (#111) Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Fixed issue101 (#114) Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Added checks for out parameters on global functions Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> Co-authored-by: Quim Muntal Diaz <quim.muntal.diaz@hp.com>
alexanderoster
added a commit
that referenced
this pull request
Jul 28, 2020
* Stringoutfix (#109) * Added String Out fix for caching string calls * Added Error checking for concurrent string and array out parameters Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Golangarrayin (#110) * Added String Out fix for caching string calls * Added Error checking for concurrent string and array out parameters * support structarray * update readme * Added Golang InArrays Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> Co-authored-by: Quim Muntal Diaz <quim.muntal.diaz@hp.com> * Fixed issue101 (#111) (#112) Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Stringoutfix (#113) * Added String Out fix for caching string calls * Added Error checking for concurrent string and array out parameters * Exchanged auto_ptr through unique_ptr Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Develop (#115) * Fixed issue101 (#111) Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Fixed issue101 (#114) Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Stringoutfix (#117) * Added String Out fix for caching string calls * Added Error checking for concurrent string and array out parameters * Exchanged auto_ptr through unique_ptr * Added checks for out parameters on global functions Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> * Cgo (#118) * support structarray * update readme * use cgo for go bindings * ensure comments finish with a dot * update readme go support * simplify cast and return strings * do not specify LDFLAGS Co-authored-by: Quim Muntal Diaz <quim.muntal.diaz@hp.com> Co-authored-by: qmuntal <quimmuntal@gmail.com> * CGo now loads functions dynamically * Fixed bugs in CGo Dynamic header generation Co-authored-by: Alexander Oster <Alexander.Oster@autodesk.com> Co-authored-by: Quim Muntal Diaz <quim.muntal.diaz@hp.com> Co-authored-by: qmuntal <quimmuntal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is an out optionalclass value, the code generator creates a base result variable:
IBase * pBaseHandlerInstance(nullptr);
This leads to a compile error of the implementation. The class should be the correct output class, like
ISignalHandler * pBaseHandlerInstance(nullptr);