Skip to content

refactor: Move metrics to a different module, rename function #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2024
Merged

refactor: Move metrics to a different module, rename function #37

merged 1 commit into from
Feb 6, 2024

Conversation

@carlosgjs
Copy link
Collaborator

@carlosgjs carlosgjs commented Feb 6, 2024 •
edited
Loading

No functional changes, just refactoring/reorganizing code:

  • Moved metrics code to a its own metrics.py module
  • Renamed evaluate_documentation to -> eval_bleu_meteor

Part of #30

@carlosgjs carlosgjs enabled auto-merge (squash) February 6, 2024 19:23
@carlosgjs carlosgjs merged commit 2a26151 into main Feb 6, 2024
@carlosgjs carlosgjs deleted the carlosg/refmetrics branch February 6, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anujsinha3 anujsinha3 anujsinha3 approved these changes

@lsetiawan lsetiawan Awaiting requested review from lsetiawan

@cdcore09 cdcore09 Awaiting requested review from cdcore09

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carlosgjs @anujsinha3