Upgrade to use AutoMapper 8

[Tasteful]

No description provided.

[Tasteful]

#2

[Tasteful]

Blocking

• Tag and make the release AutoMapper.Extensions.Microsoft.DependencyInjection#77
• Upgrade to support AutoMapper 8 AutoMapper.Extensions.ExpressionMapping#20

[TylerCarlson1]

@Tasteful Has the updates to AM resolve the Blocking?

[jbogard]

AutoMapper.Collection and friends are now published. Will take a few minutes for their index to update.

…

On Tue, Nov 20, 2018 at 12:43 PM Tyler Carlson ***@***.***> wrote: @Tasteful <https://github.com/Tasteful> Has the updates to AM resolve the Blocking? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGYMj1f-dCmPjITkZgDpg-mYjYIVN9oks5uxE1YgaJpZM4Ynlr5> .

[AppVeyorBot]

✅ Build AutoMapper.Collection.EFCore 5-jhgdbewt completed (commit 28a13478a6 by @Tasteful)

[Tasteful]

@TylerCarlson1 Everything is now ready to be merged into development. Not sure if we should bump version to 1.0.0 before merging into master and tagging for the release

[TylerCarlson1]

@Tasteful I'm less sure, but if you think it's fine for a 1.0.0 for a nuget release I'm all for it.

[TylerCarlson1]

@jbogard The build failed complaining about API key.

This hasn't been pushed on nuget yet, and the myget feed seems to have taken the nuget package

[jbogard]

Is that a completely new package?

…

On Tue, Nov 20, 2018 at 4:27 PM Tyler Carlson ***@***.***> wrote: @jbogard <https://github.com/jbogard> The build failed complaining about API key. This hasn't been pushed on nuget yet, and the myget feed seems to have taken the nuget package — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGYMn1MIvXaEl300-O8UwllNWqEEJ8Iks5uxIHBgaJpZM4Ynlr5> .

[jbogard]

Because if so it might need to be named AutoMapper.Extensions.*

…

On Tue, Nov 20, 2018 at 4:32 PM Jimmy Bogard ***@***.***> wrote: Is that a completely new package? On Tue, Nov 20, 2018 at 4:27 PM Tyler Carlson ***@***.***> wrote: > @jbogard <https://github.com/jbogard> The build failed complaining about > API key. > > This hasn't been pushed on nuget yet, and the myget feed seems to have > taken the nuget package > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#5 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAGYMn1MIvXaEl300-O8UwllNWqEEJ8Iks5uxIHBgaJpZM4Ynlr5> > . >

[TylerCarlson1]

Was thinking AutoMapper.Collection.EFCore or AutoMapper.Collection.EntityFrameworkCore which is what it is in MyGet.

If you want to follow that convention then I would suggest AutoMapper.Collection.Extensions.EFCore.
@Tasteful Not sure how you feel but I'm fine with changing the name to be consistent with the new system.

[jbogard]

I think you have to start it with Extensions

…

On Tue, Nov 20, 2018 at 4:42 PM Tyler Carlson ***@***.***> wrote: Was thinking AutoMapper.Collection.EFCore or AutoMapper.Collection.EntityFrameworkCore which is what it is in MyGet. If you want to follow that convention then I would suggest AutoMapper.Collection.Extensions.EFCore. @Tasteful <https://github.com/Tasteful> Not sure how you feel but I'm fine with changing the name to be consistent with the new system. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGYMshqfpzv55IzBbEhuqeQQDUzxFtDks5uxIVdgaJpZM4Ynlr5> .

[jbogard]

What’s the error though? I can’t see that feed.

…

On Tue, Nov 20, 2018 at 4:49 PM Jimmy Bogard ***@***.***> wrote: I think you have to start it with Extensions On Tue, Nov 20, 2018 at 4:42 PM Tyler Carlson ***@***.***> wrote: > Was thinking AutoMapper.Collection.EFCore or > AutoMapper.Collection.EntityFrameworkCore which is what it is in MyGet. > > If you want to follow that convention then I would suggest > AutoMapper.Collection.Extensions.EFCore. > @Tasteful <https://github.com/Tasteful> Not sure how you feel but I'm > fine with changing the name to be consistent with the new system. > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#5 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAGYMshqfpzv55IzBbEhuqeQQDUzxFtDks5uxIVdgaJpZM4Ynlr5> > . >

[TylerCarlson1]

https://ci.appveyor.com/project/TylerCarlson1/automapper-collection-efcore/builds/20445749

Ending lines if can't read it.

Uploading artifacts...
[1/2] artifacts\AutoMapper.Collection.EntityFrameworkCore.0.1.0-ci-00005.nupkg (12,462 bytes)...100%
[2/2] artifacts\AutoMapper.Collection.EntityFrameworkCore.0.1.0-ci-00005.symbols.nupkg (15,716 bytes)...100%
"NuGet" deployment for branch "master" has been skipped because current branch is "development"
"NuGet" deployment has been skipped as environment variable has not matched ("appveyor_repo_tag" is "false", should be "true")
Deploying using NuGet provider
Provider setting not found or it's value is empty. If secure setting is used please check that value was encrypted (or YAML was exported) while being logged under correct account.
Parameter name: api_key

It's possible I didn't set the up correctly and it's trying to go to nuget, but I doubt it.

[Tasteful]

Version number does not matter for me, i was more thinking of first release to nuget maybe should have 1.0.0 and not 0.1.0 but we can push it as 0.1.0 do indicate that it is still new and not have come to the first stable major release.

The naming does not matter for me either, named it to AutoMapper.Collection.EntityFrameworkCore to match with the already existing package AutoMapper.Collection.EntityFramework. Will it not be confused if we have the AutoMapper.Collection.EntityFramework and the AutoMapper.Collection.Extensions.EntityFrameworkCore or should the first package also be renamed? And we also have the AutoMapper.Collection that probably should be renamed in that case also to AutoMapper.Extensions.Collection because it is an extension to AutoMapper.

The reason the build is failing is that the appveyor is setup on @TylerCarlson1 account and not as all the other projects on @jbogard account. The encrypted passwords in the package will only match for projects build and connected to @jbogard account.

[jbogard]

I’ll connect it to my account then. And we can keep the original name then.

…

On Wed, Nov 21, 2018 at 1:22 AM Patric Forsgard ***@***.***> wrote: Version number does not matter for me, i was more thinking of first release to nuget maybe should have 1.0.0 and not 0.1.0 but we can push it as 0.1.0 do indicate that it is still new and not have come to the first stable major release. The naming does not matter for me either, named it to AutoMapper.Collection.EntityFrameworkCore to match with the already existing package AutoMapper.Collection.EntityFramework. Will it not be confused if we have the ``AutoMapper.Collection.EntityFrameworkand theAutoMapper.Collection.Extensions.EntityFrameworkCore` or should the first package also be renamed? And we also have the `AutoMapper.Collection` that probably should be renamed in that case also to `AutoMapper.Extensions.Collection` because it is an extension to `AutoMapper`. The reason the build is failing is that the appveyor is setup on @TylerCarlson1 <https://github.com/TylerCarlson1> account and not as all the other projects on @jbogard <https://github.com/jbogard> account. The encrypted passwords in the package will only match for projects build and connected to @jbogard <https://github.com/jbogard> account. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGYMuJQOYc_8uo7mfKhsREL0MK47tjUks5uxP8-gaJpZM4Ynlr5> .