Skip to content

fix: Pass SettingsService to spec generation so runtime uses persisted model #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcbodge wants to merge 2 commits into from
Closed

fix: Pass SettingsService to spec generation so runtime uses persisted model #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b0cfd
feat: pass settingsService to createCreateHandler for enhanced spec c…
mcbodge Jan 20, 2026
4661a4b
feat: remove eventHooks from settings hydration and update builder fu…
mcbodge Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apps/server/src/routes/app-spec/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ export function createSpecRegenerationRoutes(
settingsService?: SettingsService
): Router {
const router = Router();

router.post('/create', createCreateHandler(events));
router.post('/create', createCreateHandler(events, settingsService));
router.post('/generate', createGenerateHandler(events, settingsService));
router.post('/generate-features', createGenerateFeaturesHandler(events, settingsService));
router.post('/sync', createSyncHandler(events, settingsService));
Expand Down
6 changes: 4 additions & 2 deletions apps/server/src/routes/app-spec/routes/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import type { Request, Response } from 'express';
import type { EventEmitter } from '../../../lib/events.js';
import type { SettingsService } from '../../../services/settings-service.js';
import { createLogger } from '@automaker/utils';
import {
getSpecRegenerationStatus,
Expand All @@ -16,7 +17,7 @@ import { generateSpec } from '../generate-spec.js';

const logger = createLogger('SpecRegeneration');

export function createCreateHandler(events: EventEmitter) {
export function createCreateHandler(events: EventEmitter, settingsService?: SettingsService) {
return async (req: Request, res: Response): Promise<void> => {
logger.info('========== /create endpoint called ==========');
logger.debug('Request body:', JSON.stringify(req.body, null, 2));
Expand Down Expand Up @@ -68,7 +69,8 @@ export function createCreateHandler(events: EventEmitter) {
abortController,
generateFeatures,
analyzeProject,
maxFeatures
maxFeatures,
settingsService
)
.catch((error) => {
logError(error, 'Generation failed with error');
Expand Down
3 changes: 0 additions & 3 deletions apps/ui/src/hooks/use-settings-migration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,8 +730,6 @@ export function hydrateStoreFromSettings(settings: GlobalSettings): void {
worktreePanelCollapsed: settings.worktreePanelCollapsed ?? false,
lastProjectDir: settings.lastProjectDir ?? '',
recentFolders: settings.recentFolders ?? [],
// Event hooks
eventHooks: settings.eventHooks ?? [],
// Terminal font (nested in terminalState)
...(settings.terminalFontFamily && {
terminalState: {
Expand Down Expand Up @@ -810,7 +808,6 @@ function buildSettingsUpdateFromStore(): Record<string, unknown> {
lastProjectDir: state.lastProjectDir,
recentFolders: state.recentFolders,
terminalFontFamily: state.terminalState.fontFamily,
eventHooks: state.eventHooks,
};
}

Expand Down