refactor: migrate frontend from next.js to vite + tanStack router #148
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| name: "Setup Project" | ||
| description: "Common setup steps for CI workflows - checkout, Node.js, dependencies, and native modules" | ||
|
|
||
| inputs: | ||
| node-version: | ||
| description: "Node.js version to use" | ||
| required: false | ||
| default: "22" | ||
| check-lockfile: | ||
| description: "Run lockfile lint check for SSH URLs" | ||
| required: false | ||
| default: "false" | ||
| rebuild-node-pty-path: | ||
| description: "Working directory for node-pty rebuild (empty = root)" | ||
| required: false | ||
| default: "" | ||
|
|
||
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ inputs.node-version }} | ||
| cache: "npm" | ||
| cache-dependency-path: package-lock.json | ||
|
|
||
| - name: Check for SSH URLs in lockfile | ||
| if: inputs.check-lockfile == 'true' | ||
| shell: bash | ||
| run: npm run lint:lockfile | ||
|
|
||
| - name: Configure Git for HTTPS | ||
| shell: bash | ||
| # Convert SSH URLs to HTTPS for git dependencies (e.g., @electron/node-gyp) | ||
| # This is needed because SSH authentication isn't available in CI | ||
| run: git config --global url."https://github.com/".insteadOf "git@github.com:" | ||
|
|
||
| - name: Install dependencies | ||
| shell: bash | ||
| # Use npm install instead of npm ci to correctly resolve platform-specific | ||
| # optional dependencies (e.g., @tailwindcss/oxide, lightningcss binaries) | ||
| # Skip scripts to avoid electron-builder install-app-deps which uses too much memory | ||
| run: npm install --ignore-scripts | ||
|
|
||
| - name: Install Linux native bindings | ||
| shell: bash | ||
| # Workaround for npm optional dependencies bug (npm/cli#4828) | ||
| # Explicitly install Linux bindings needed for build tools | ||
| run: | | ||
| npm install --no-save --force --ignore-scripts \ | ||
| @rollup/rollup-linux-x64-gnu@4.53.3 \ | ||
| @tailwindcss/oxide-linux-x64-gnu@4.1.17 | ||
|
|
||
| - name: Rebuild native modules (root) | ||
| if: inputs.rebuild-node-pty-path == '' | ||
| shell: bash | ||
| # Rebuild node-pty and other native modules for Electron | ||
| run: npm rebuild node-pty | ||
|
Contributor
There was a problem hiding this comment. The run: npm rebuild |
||
|
|
||
| - name: Rebuild native modules (workspace) | ||
| if: inputs.rebuild-node-pty-path != '' | ||
| shell: bash | ||
| # Rebuild node-pty and other native modules needed for server | ||
| run: npm rebuild node-pty | ||
|
Contributor
There was a problem hiding this comment. Similar to the root rebuild step, this command only rebuilds run: npm rebuild |
||
| working-directory: ${{ inputs.rebuild-node-pty-path }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These native binding versions are hardcoded. This could become a maintenance issue if the parent dependencies (
@rollup/rollupor@tailwindcss/vite) are updated and require different versions of these optional native modules.To improve maintainability, I suggest adding a comment here to remind future developers to update these versions when the corresponding parent dependencies change in
package.json.