feat(routerchannel): support api for querying RouterChannelEpoch#3331
Merged
Conversation
allenzhu
requested review from
1sonofqiu,
Gezi-lzq,
superhx and
woshigaopp
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds RouterChannelEpoch visibility through the existing AutoMQ getNodes API so clients/tools can query the cluster-level router channel epoch from the controller.
Changes:
- Expose RouterChannelEpoch from
RouterChannelEpochControlManagerand attach it toAutomqGetNodesResponse. - Extend the protocol schema (
AutomqGetNodesResponse.json) with a taggedRouterChannelEpochstruct. - Extend AdminClient
GetNodesResult/KafkaAdminClient#getNodesto surface the epoch to callers; print it inautomq-shell cluster describe.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| metadata/src/main/java/org/apache/kafka/controller/stream/RouterChannelEpochControlManager.java | Adds an accessor to expose the current RouterChannelEpoch. |
| metadata/src/main/java/org/apache/kafka/controller/QuorumController.java | Populates RouterChannelEpoch into AutomqGetNodesResponseData. |
| clients/src/main/resources/common/message/AutomqGetNodesResponse.json | Adds a tagged RouterChannelEpoch field/struct to the response schema. |
| clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java | Parses RouterChannelEpoch from response and returns it via an additional future. |
| clients/src/main/java/org/apache/kafka/clients/admin/GetNodesResult.java | Adds routerChannelEpoch() future and a RouterChannelEpoch value class. |
| automq-shell/src/main/java/com/automq/shell/commands/cluster/Describe.java | Displays RouterChannelEpoch in cluster describe output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
superhx
reviewed
Apr 28, 2026
superhx
reviewed
Apr 28, 2026
superhx
reviewed
Apr 28, 2026
superhx
approved these changes
Apr 29, 2026
allenzhu
added a commit
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.