refactor: move flush scheduler into ClusterEventPublisher with ClusterEventEmitter interface#3326
Merged
Merged
Conversation
…rEventEmitter interface - Add ClusterEventEmitter functional interface with emit(IClusterEventPublisher) - ClusterEventPublisher owns a static scheduled flush loop (30s interval) - Accumulators register via registerEmitter()/removeEmitter() - RequestErrorAccumulator implements ClusterEventEmitter, no longer owns scheduler - RPS calculation uses real elapsed time instead of hardcoded interval - BrokerServer registers RequestErrorAccumulator as emitter on startup
superhx
requested review from
1sonofqiu,
Gezi-lzq and
woshigaopp
as code owners
Gezi-lzq
approved these changes
Apr 20, 2026
superhx
added a commit
that referenced
this pull request
Apr 22, 2026
…rEventEmitter interface (#3326) Move the periodic flush scheduler from individual accumulators into `ClusterEventPublisher` as a centralized mechanism. Accumulators now implement `ClusterEventEmitter` and register themselves with the publisher. - **`ClusterEventEmitter`** (new): `@FunctionalInterface` with `void emit(IClusterEventPublisher)` - **`ClusterEventPublisher`**: owns a static daemon scheduled executor (30s interval) that invokes all registered emitters. `setup()`/`shutdown()` only manage the producer and emitter list. - **`RequestErrorAccumulator`**: implements `ClusterEventEmitter`, no longer owns its own scheduler. RPS calculation uses real elapsed wall-clock time. - **`BrokerServer.scala`**: registers `RequestErrorAccumulator` as an emitter; no longer calls `close()` on it separately. Signed-off-by: Robin Han <hanxvdovehx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the periodic flush scheduler from individual accumulators into
ClusterEventPublisheras a centralized mechanism. Accumulators now implementClusterEventEmitterand register themselves with the publisher.Changes
ClusterEventEmitter(new):@FunctionalInterfacewithvoid emit(IClusterEventPublisher)ClusterEventPublisher: owns a static daemon scheduled executor (30s interval) that invokes all registered emitters.setup()/shutdown()only manage the producer and emitter list.RequestErrorAccumulator: implementsClusterEventEmitter, no longer owns its own scheduler. RPS calculation uses real elapsed wall-clock time.BrokerServer.scala: registersRequestErrorAccumulatoras an emitter; no longer callsclose()on it separately.