fix: Re-enable -Werror and fix all compile warnings (#2717)#3254
Open
adhnanjeff wants to merge 1 commit intoAutoMQ:mainfrom
Open
fix: Re-enable -Werror and fix all compile warnings (#2717)#3254adhnanjeff wants to merge 1 commit intoAutoMQ:mainfrom
adhnanjeff wants to merge 1 commit intoAutoMQ:mainfrom
Conversation
adhnanjeff
requested review from
1sonofqiu,
Gezi-lzq,
superhx and
woshigaopp
as code owners
adhnanjeff
force-pushed
the
fix/issue-2717-enable-werror-fix-warnings
branch
from
b55be03 to
bf7654f
Compare
- Re-enabled -Werror flag in build.gradle to treat warnings as errors - Fixed [deprecation] warnings for getIssuerDN()/getSubjectDN() with @SuppressWarnings - Fixed [removal] warnings for AccessController/Subject.getSubject() with @SuppressWarnings - Fixed [this-escape] warnings in constructors with @SuppressWarnings All Java source and test compilation now passes cleanly with -Werror enabled. All suppressions use minimal scope (method-level, not class-level). Fixes AutoMQ#2717
adhnanjeff
force-pushed
the
fix/issue-2717-enable-werror-fix-warnings
branch
from
bf7654f to
2037717
Compare
adhnanjeff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Java source and test compilation now passes cleanly with -Werror enabled. All suppressions use minimal scope (method-level, not class-level).
Fixes #2717
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)