feat(s3): isolated default credentials#3199
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the AWS credentials provider instantiation in the AwsObjectStorage class from using the static factory method to the builder pattern, improving code consistency with other parts of the codebase.
Changes:
- Updated
DefaultCredentialsProvider.create()toDefaultCredentialsProvider.builder().build()in thecredentialsProviders0method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
superhx
approved these changes
Feb 2, 2026
woshigaopp
added a commit
that referenced
this pull request
Feb 2, 2026
superhx
pushed a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the way AWS credentials providers are instantiated in the
AwsObjectStorageclass. The change replaces the direct use ofDefaultCredentialsProvider.create()with the builder patternDefaultCredentialsProvider.builder().build(), which can provide better extensibility and clarity.credentialsProviders0method inAwsObjectStorage.javato useDefaultCredentialsProvider.builder().build()instead ofDefaultCredentialsProvider.create().