-
Notifications
You must be signed in to change notification settings - Fork 522
fix(binder): enhance RecordBinder and TypeAdapter to support STRUCT type conversion #3005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gezi-lzq
wants to merge
4
commits into
main
Choose a base branch
from
fix/struct
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0c4e9ef
fix(binder): enhance RecordBinder and TypeAdapter to support STRUCT t…
Gezi-lzq 8964a8d
test(binder): add tests for nested struct binding and schema instance…
Gezi-lzq 0a3f410
fix(adapter): support conversion from Number to TIMESTAMPTZ in Abstra…
Gezi-lzq 79ef386
fix(adapter): update list and map conversion methods to include Struc…
Gezi-lzq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
core/src/main/java/kafka/automq/table/binder/FieldMapping.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Copyright 2025, AutoMQ HK Limited. | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package kafka.automq.table.binder; | ||
Gezi-lzq marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| import org.apache.avro.Schema; | ||
| import org.apache.iceberg.types.Type; | ||
|
|
||
| /** | ||
| * Represents the mapping between an Avro field and its corresponding Iceberg field. | ||
| * This class stores the position, key, schema, and type information needed to | ||
| * convert field values during record binding. | ||
| */ | ||
| public class FieldMapping { | ||
| private final int avroPosition; | ||
| private final String avroKey; | ||
| private final Type icebergType; | ||
| private final Schema avroSchema; | ||
|
|
||
| public FieldMapping(int avroPosition, String avroKey, Type icebergType, Schema avroSchema) { | ||
| this.avroPosition = avroPosition; | ||
| this.avroKey = avroKey; | ||
| this.icebergType = icebergType; | ||
| this.avroSchema = avroSchema; | ||
| } | ||
|
|
||
| public int avroPosition() { | ||
| return avroPosition; | ||
| } | ||
|
|
||
| public String avroKey() { | ||
| return avroKey; | ||
| } | ||
|
|
||
| public Type icebergType() { | ||
| return icebergType; | ||
| } | ||
|
|
||
| public Schema avroSchema() { | ||
| return avroSchema; | ||
| } | ||
| } | ||
Gezi-lzq marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.