feat(kv): enhance namespaced key-value store operations and handlers #2613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rolManager initialization
…d read/write tests
…and update response handling
|
Missing modification of KVImage |
superhx
reviewed
Jun 6, 2025
| * @param keyAndNamespace key and namespace. | ||
| * @return async get result. {@link ValueAndEpoch} value and epoch, null if key not exist. | ||
| */ | ||
| CompletableFuture<ValueAndEpoch> getNamespacedKV(KeyAndNamespace keyAndNamespace); |
There was a problem hiding this comment.
Could we modify the Key with additional namespace field instead of create a new class
| this.epoch = 0L; | ||
| } | ||
|
|
||
| public KeyValue(Key key, Value value, String namespace, long epoch) { |
There was a problem hiding this comment.
Add the doc for epoch field
| @@ -47,30 +50,54 @@ public class KVControlManager { | |||
| private final SnapshotRegistry registry; | |||
| private final Logger log; | |||
| private final TimelineHashMap<String, ByteBuffer> kv; | |||
| private final TimelineHashMap<String, KeyMetadata> keyMetadataMap; | |||
There was a problem hiding this comment.
Maybe we don't need keyMetadata. We could just assign a special namespace&epoch to the old KV.
| * @param options | ||
| * @return | ||
| */ | ||
| PutNamespacedKVResult putNamespacedKV( |
There was a problem hiding this comment.
Why does the parameter "partitions" exist?
| @@ -4866,6 +4877,86 @@ public UpdateGroupResult updateGroup(String groupId, UpdateGroupSpec groupSpec, | |||
| return new UpdateGroupResult(future.get(CoordinatorKey.byGroupId(groupId))); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
Please add AutoMQ extended code in the last of file and wrap the code with AutoMQ inject start / end.
| @@ -0,0 +1,23 @@ | |||
| package org.apache.kafka.clients.admin; | |||
| "name": "Epoch", | ||
| "type": "int64", | ||
| "versions": "1+", | ||
| "about": "Epoch" |
| .setEpoch(currentEpoch)); | ||
| } | ||
|
|
||
| long newEpoch = System.currentTimeMillis(); |
There was a problem hiding this comment.
We should use a incremental epoch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)