refactor(s3stream): in preparation for segmented recovery #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
superhx
approved these changes
May 23, 2025
Chillax-0v0
added a commit
that referenced
this pull request
May 23, 2025
* refacotr: remove useless param passing Signed-off-by: Ning Yu <ningyu@automq.com> * revert: "release Bytebuf allocated by WAL earlier to prevent memory fragmentation (#2341)" This reverts commit 7b4240a. * refactor: extract `filterOutInvalidStreams` Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: extract `releaseRecords` Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: rename "expectXXX" to "expectedXXX" Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: extract methods Signed-off-by: Ning Yu <ningyu@automq.com> --------- Signed-off-by: Ning Yu <ningyu@automq.com>
superhx
pushed a commit
that referenced
this pull request
May 23, 2025
) * refacotr: remove useless param passing * revert: "release Bytebuf allocated by WAL earlier to prevent memory fragmentation (#2341)" This reverts commit 7b4240a. * refactor: extract `filterOutInvalidStreams` * refactor: extract `releaseRecords` * refactor: rename "expectXXX" to "expectedXXX" * refactor: extract methods --------- Signed-off-by: Ning Yu <ningyu@automq.com>
Chillax-0v0
added a commit
that referenced
this pull request
May 26, 2025
* refacotr: remove useless param passing Signed-off-by: Ning Yu <ningyu@automq.com> * revert: "release Bytebuf allocated by WAL earlier to prevent memory fragmentation (#2341)" This reverts commit 7b4240a. * refactor: extract `filterOutInvalidStreams` Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: extract `releaseRecords` Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: rename "expectXXX" to "expectedXXX" Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: extract methods Signed-off-by: Ning Yu <ningyu@automq.com> --------- Signed-off-by: Ning Yu <ningyu@automq.com>
Chillax-0v0
added a commit
that referenced
this pull request
May 28, 2025
* refactor(s3stream): in preparation for segmented recovery (#2589) * refacotr: remove useless param passing Signed-off-by: Ning Yu <ningyu@automq.com> * revert: "release Bytebuf allocated by WAL earlier to prevent memory fragmentation (#2341)" This reverts commit 7b4240a. * refactor: extract `filterOutInvalidStreams` Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: extract `releaseRecords` Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: rename "expectXXX" to "expectedXXX" Signed-off-by: Ning Yu <ningyu@automq.com> * refactor: extract methods Signed-off-by: Ning Yu <ningyu@automq.com> --------- Signed-off-by: Ning Yu <ningyu@automq.com> * refactor(s3stream): preparation for segmented recovery (#2591) Signed-off-by: Ning Yu <ningyu@automq.com> * perf(s3stream): recover and upload data in segments (#2593) * feat: pause recovery once the cache is full Signed-off-by: Ning Yu <ningyu@automq.com> * feat(s3stream): recover and upload data in segments Signed-off-by: Ning Yu <ningyu@automq.com> * test: test segmented recovery Signed-off-by: Ning Yu <ningyu@automq.com> --------- Signed-off-by: Ning Yu <ningyu@automq.com> --------- Signed-off-by: Ning Yu <ningyu@automq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fully equivalent reconstruction.