[CLEANUP] Replace deprecated X509Certificate.getSubjectDN() and getIssuerDN() with X500Principal equivalents

[manmohak07]

Summary

CommonNameLoggingTrustManagerFactoryWrapper.java in the clients module uses X509Certificate.getSubjectDN() and X509Certificate.getIssuerDN(), both deprecated since JDK 16. The build produces deprecation warnings:

CommonNameLoggingTrustManagerFactoryWrapper.java:374: warning: [deprecation] getSubjectDN() in X509Certificate has been deprecated 
CommonNameLoggingTrustManagerFactoryWrapper.java:375: warning: [deprecation] getSubjectDN() in X509Certificate has been deprecated 
CommonNameLoggingTrustManagerFactoryWrapper.java:324: warning: [deprecation] getIssuerDN() in X509Certificate has been deprecated 
CommonNameLoggingTrustManagerFactoryWrapper.java:325: warning: [deprecation] getIssuerDN() in X509Certificate has been deprecated

Fix

With respect to this: https://bugs.openjdk.org/browse/JDK-4959744, I think we can replace the deprecated methods with their recommended alternatives:
getSubjectDN() -> getSubjectX500Principal()
getIssuerDN() -> getIssuerX500Principal()

Both return X500Principal instead of Principal. The X500Principal class provides a well-defined getName() method with RFC 2253 output, whereas the old getSubjectDN() / getIssuerDN() had implementation-dependent behavior.

[itsmohitnarayan]

Hi, I'd like to work on this issue. I've previously contributed PR #3102 (CWE-129 array bounds fix) which was merged. Will submit a PR shortly.

[Tripathi-Nishant]

Hi maintainers, I’d like to take this issue.

Problem: CommonNameLoggingTrustManagerFactoryWrapper.java uses deprecated X509Certificate.getSubjectDN() / getIssuerDN(), causing warnings on JDK 16+.

Proposed solution: Replace with getSubjectX500Principal() / getIssuerX500Principal() and use X500Principal#getName() for logging to keep the same output.
I can submit a PR once confirmed.

[itsmohitnarayan]

Hi maintainers, I’d like to take this issue.

Problem: CommonNameLoggingTrustManagerFactoryWrapper.java uses deprecated X509Certificate.getSubjectDN() / getIssuerDN(), causing warnings on JDK 16+.

Proposed solution: Replace with getSubjectX500Principal() / getIssuerX500Principal() and use X500Principal#getName() for logging to keep the same output.
I can submit a PR once confirmed.

a pr to this issue is already there