-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add support for Avro message production with new schema versions (V3 and V4) #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Gezi-lzq
wants to merge
4
commits into
main
Choose a base branch
from
test/scheam-changed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
83878ad
feat: add support for Avro message production with new schema version…
Gezi-lzq b6604d4
feat: add support for producing Avro messages with OrderV5 schema
Gezi-lzq d033b37
feat: update Avro message production to use OrderV3 schema and remove…
Gezi-lzq 75a4b87
feat: add support for producing Avro messages with OrderV4 schema
Gezi-lzq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
table-topic-solutions/playground/append-scenario/schemas/OrderV3.avsc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "type": "record", | ||
| "name": "Order", | ||
| "namespace": "demo.append", | ||
| "fields": [ | ||
| {"name": "order_id", "type": "long"}, | ||
| {"name": "product_name", "type": "string"}, | ||
| {"name": "order_description", "type": ["null", "string"], "default": null}, | ||
| {"name": "f_v3", "type": ["null", "string"], "default": null} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in my example I used obligatory field - I think I tried to specify as optional first and later redefine to obligatory but that indeed would be incompatible schema evolution. (not sure if that will matter but just mentioning) |
||
| ] | ||
| } | ||
12 changes: 12 additions & 0 deletions
12
table-topic-solutions/playground/append-scenario/schemas/OrderV4.avsc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "type": "record", | ||
| "name": "Order", | ||
| "namespace": "demo.append", | ||
| "fields": [ | ||
| {"name": "order_id", "type": "long"}, | ||
| {"name": "product_name", "type": "string"}, | ||
| {"name": "order_description", "type": ["null", "string"], "default": null}, | ||
| {"name": "f_v2", "type": ["null", "string"], "default": null}, | ||
| {"name": "f_v3", "type": ["null", "string"], "default": null} | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice idea with this field versioning - easy to follow and see what is new and in case of more changes needed can be still possible to follow without making diffs on those files