Safari support

[rebornix]

Fix #651

This PR adds changes we need to allow the plugin to be runnable on macOS safari, which includes:

• browser utility to check browser type (isChrome, isFirefox, isSafari)
• Conditionally disable features which don't work on Safari
  • Disable chrome.storage.managed in Safari
  • Limited backup
• A new theme flat which fit better in Safari

[Sneezry]

Can we use blobl URLs (https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL) so that we can also enable backup feature on Safari?

[rebornix]

Unfortunately we don't have blob url support either on Safari, IIRC blob urls can't be opened.

[rebornix]

The only available on Safari for now is file download. I didn't figure out an approach for working around for other backup solutions yet.

[Sneezry]

https://developer.apple.com/forums/thread/657490 seems a bug for Safari

[Sneezry]

I don't see the change for build script, do we need a new entry in build script for Safari web extension?

[rebornix]

I don't see the change for build script, do we need a new entry in build script for Safari web extension?

@Sneezry We can reuse the chrome one since there aren't differences between compiling the extension for chromium and safari (exactly what Safari team aims for). The extension will behave differently at runtime.

[Sneezry]

I don't see the change for build script, do we need a new entry in build script for Safari web extension?

@Sneezry We can reuse the chrome one since there aren't differences between compiling the extension for chromium and safari (exactly what Safari team aims for). The extension will behave differently at runtime.

Then how can we build the extension for Safari, does npm run chrome work?

[rebornix]

Then how can we build the extension for Safari, does npm run chrome work?

@Sneezry Yes. Sorry that I didn't document how to test Safari. The steps would be

• Clone https://github.com/rebornix/Authen
• Update sub modules
• Inside Authenticator, run npm install && npm run chrome
• Launch the xcode project and run

It's a pity that there is no hot reload. Let me know where is the best place for above steps, they can be documented in https://github.com/rebornix/Authen but it makes sense to me to have it in this project too.

[Sneezry]

LGTM

[rebornix]

@mymindstorm I would really appreciate your help if you can also take a look at this PR, thanks in advance!

[mymindstorm]

Sorry about the delay, I'll get this reviewed by the end of today.

[mymindstorm]

It's a pity that there is no hot reload. Let me know where is the best place for above steps, they can be documented in rebornix/Authen but it makes sense to me to have it in this project too.

Since this is the official safari port, how about we move rebornix/Authen into the Authenticator-Extension organization account, add the Safari build steps to @rebornix 's repository, and link to that from this repository?

[rebornix]

If @Sneezry has no objection I can start moving my repo to this organization and then update the steps and links in this PR.

[rebornix]

@mymindstorm @Sneezry I have already moved the Safari wrapper repository into this org and updated the readme with links to its contribution/development steps. Please help take a look ;)

[Sneezry]

@mymindstorm @Sneezry I have already moved the Safari wrapper repository into this org and updated the readme with links to its contribution/development steps. Please help take a look ;)

Cool! The sub-module reference may need to update

[rebornix]

@Sneezry good catch! Updated the git-submodule link and will update the commit once we merge this PR. Let me know if the PR is good for merge, thanks!