Skip to content

use blob url to replace data url #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2022
Merged

use blob url to replace data url #817

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions src/components/Popup/BackupPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
</template>
<script lang="ts">
import Vue from "vue";
import { mapState } from "vuex";
import { Encryption } from "../../models/encryption";
import { EntryStorage } from "../../models/storage";
import * as CryptoJS from "crypto-js";

export default Vue.extend({
data: function () {
Expand Down Expand Up @@ -152,10 +148,7 @@ function getBackupFile(
let json = JSON.stringify(entryData, null, 2);
// for windows notepad
json = json.replace(/\n/g, "\r\n");
const base64Data = CryptoJS.enc.Base64.stringify(
CryptoJS.enc.Utf8.parse(json)
);
return `data:application/octet-stream;base64,${base64Data}`;
return downloadFileUrlBuilder(json);
}

function getOneLineOtpBackupFile(entryData: { [hash: string]: OTPStorage }) {
Expand Down Expand Up @@ -198,10 +191,12 @@ function getOneLineOtpBackupFile(entryData: { [hash: string]: OTPStorage }) {
otpAuthLines.push(otpAuthLine);
}

const base64Data = CryptoJS.enc.Base64.stringify(
CryptoJS.enc.Utf8.parse(otpAuthLines.join("\r\n"))
);
return `data:application/octet-stream;base64,${base64Data}`;
return downloadFileUrlBuilder(otpAuthLines.join("\r\n"));
}

function downloadFileUrlBuilder(content: string) {
const blob = new Blob([content], { type: "application/octet-stream" });
return URL.createObjectURL(blob);
}

function removeUnsafeData(data: string) {
Expand Down