Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: project Card for decentralized projects (UI) #1913

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Conversation

rkzel
Copy link
Collaborator

@rkzel rkzel commented Jan 23, 2020

GH Projects, with and without bounty. Description gets truncated after 3 lines - should depend on whether there are bounties available? If there are no bounties, truncate after 5 lines?

Screenshot from 2020-01-23 14-08-44

Decentralized project with a bounty:

Screenshot from 2020-01-23 14-18-55

Context Menu of decentralized project:

Screenshot from 2020-01-23 14-19-13

Context Menu of GH project:

Screenshot from 2020-01-23 14-08-00

@rkzel rkzel requested a review from chadoh January 23, 2020 14:17
@rkzel rkzel requested a review from a team as a code owner January 23, 2020 14:17
@ghost ghost removed their request for review January 23, 2020 14:17
Copy link
Collaborator

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@chadoh chadoh requested a review from javieralaves January 23, 2020 15:23
@chadoh
Copy link
Collaborator

chadoh commented Jan 23, 2020

@javieralaves see Radek's design question at the top of his description (above the first screenshot)

@chadoh chadoh assigned javieralaves and unassigned chadoh Jan 23, 2020
Copy link
Collaborator

@javieralaves javieralaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chadoh @rkzel To answer the question: Keep truncation at 3 lines regardless of the rest of the card structure; otherwise we'd be displaying too much text. This looks good!

@javieralaves javieralaves assigned rkzel and unassigned javieralaves Jan 23, 2020
@rkzel rkzel merged commit b132179 into dev Jan 23, 2020
rkzel added a commit that referenced this pull request Jan 30, 2020
…-Review-Panels-update-1

* 'dev' of github.com:AutarkLabs/open-enterprise: (30 commits)
  fix(vote slider): add theme for slider background
  fix(dot-voting): dark mode support for voting bars
  fix: change radspec for newVote
  fix:  Very small dot-voting participation rounded
  fix(recovery script): error on invalid allocations period length
  refactor: feature-flip, ThematicBreak
  fix(projects): use main component with emptywrapper
  fix(projects): ignore bounties made before Nov 26
  feat(projects): add proper "Back" to IssueDetail
  fix: hidden InfoBox, adjusted ScrollList height, fixed intendation
  fix: projects card bounties description and deadline
  feat(projects): bounties tab
  refactor: github query component and post-review fixes
  feat: dark mode
  feat: project Card for decentralized projects (#1913)
  perf: disabled react-axe
  refactor(projects): move hook out of Issue card
  refactor: remove unused 'query' logic from usePathHelpers
  feat(projects): remake issues tab as project detail
  fix(dot-voting): smooth transition for side panel
  ...
@rkzel rkzel deleted the 1895-projects-card branch February 7, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants