Allocations/routing: wait, don't redirect #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterMPhillips
previously approved these changes
Dec 16, 2019
added 2 commits
December 16, 2019 17:06
Since it can take quite some time from initial load of an app until the time that it may have enough data loaded to show a certain URL, we do not want to change the route if no matching item is found. Instead, we want to ignore the unknown URL. This sets us up to do that by making the BudgetDetail component ignore routing, instead passing `budget` in as a prop. This allows all routing logic to be located in the Routes component in App.js. This also means that we can entirely remove the patientlyRequestPath function. When doing this, I noticed that nothing is using the `path` export from `usePathHelpers`, so I also removed it.
Rather than some files using raw `usePath` and some using
`usePathHelpers`, I think it makes sense to standardize on
`usePathHelpers` everywhere.
I also prefer the named import (`{ requestPath }`) to the positional
import (`[ , requestPath ]`)
chadoh
force-pushed
the
allocations-routing
branch
from
5f2a9e4 to
7bd6d4b
Compare
|
Ah, great point, @PeterMPhillips! I removed it |
PeterMPhillips
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it can take quite some time from initial load of an app until the time that it may have enough data loaded to show a certain URL, we do not want to change the route if no matching item is found. Instead, we want to ignore the unknown URL.
This sets us up to do that by making the BudgetDetail component ignore routing, instead passing
budgetin as a prop. This allows all routing logic to be located in the Routes component in App.js.I also standardized on
usePathHelpers, rather than sometimes using rawusePath.