fix: remove send_email flag everywhere

Author: amandazhuyilan

config.py

@@ -16,7 +16,6 @@ class Settings(BaseSettings):
     jwt_secret_key: str
     auth0_algorithms: list[str] = ["RS256"]
     admin_roles: list[str] = []
-    send_email: bool = False
     # Note we process this separately in app startup as it needs
     #   to be available before the app starts
     cors_allowed_origins: str

routers/admin.py

@@ -638,7 +638,7 @@ def approve_group_membership(user_id: Annotated[str, UserIdParam],
         client=client,
         db_session=db_session,
     )
-    if status_changed and settings.send_email and membership.user and membership.user.email:
+    if status_changed and membership.user and membership.user.email:
         background_tasks.add_task(
             send_group_membership_approved_email,
             membership.user.email,

routers/biocommons_groups.py

@@ -70,12 +70,16 @@ def request_group_access(
         updated_by=None
     )
     membership.save(session=db_session, commit=True)
-    if settings.send_email:
-        logger.info("Sending emails to group admins for approval")
-        admin_emails = membership.group.get_admins(auth0_client=auth0_client)
-        for email in admin_emails:
-            background_tasks.add_task(send_group_approval_email,
-                                      approver_email=email, request=membership, email_service=email_service, settings=settings)
+    logger.info("Sending emails to group admins for approval")
+    admin_emails = membership.group.get_admins(auth0_client=auth0_client)
+    for email in admin_emails:
+        background_tasks.add_task(
+            send_group_approval_email,
+            approver_email=email,
+            request=membership,
+            email_service=email_service,
+            settings=settings,
+        )
     return {"message": f"Group membership for {group_id} requested successfully."}
 
 
@@ -118,7 +122,7 @@ def approve_group_access(
     membership.save(session=db_session, commit=True)
     if membership.user is None:
         db_session.refresh(membership, attribute_names=["user"])
-    if settings.send_email and membership.user and membership.user.email:
+    if membership.user and membership.user.email:
         background_tasks.add_task(
             send_group_membership_approved_email,
             membership.user.email,

routers/biocommons_register.py

@@ -104,9 +104,8 @@ async def register_biocommons_user(
             auth0_client=auth0_client
         )
         # Send approval email in the background
-        if bundle is not None:
-            if settings.send_email and not bundle.group_auto_approve:
-                background_tasks.add_task(send_approval_email, registration, settings)
+        if bundle is not None and not bundle.group_auto_approve:
+            background_tasks.add_task(send_approval_email, registration, settings)
 
         logger.info(
             f"Successfully registered biocommons user: {auth0_user_data.user_id}"

routers/sbp_register.py

@@ -97,9 +97,8 @@ async def register_sbp_user(
         _create_sbp_user_record(auth0_user_data, auth0_client=auth0_client, session=db_session)
 
         # Send approval email in the background
-        if settings.send_email:
-            background_tasks.add_task(send_approval_email, registration, settings)
-            logger.info("Approval email queued for sending")
+        background_tasks.add_task(send_approval_email, registration, settings)
+        logger.info("Bundle approval email queued for sending")
 
         return {"message": "User registered successfully. Approval pending.", "user": auth0_user_data.model_dump(mode="json")}
 

tests/conftest.py

@@ -135,7 +135,6 @@ def mock_settings():
         auth0_db_connection="Username-Password-Authentication",
         jwt_secret_key="mock-secret-key",
         cors_allowed_origins="https://test",
-        send_email=False,
         admin_roles=["Admin"],
         auth0_algorithms=["RS256"]
     )
@@ -174,7 +173,6 @@ def test_client_with_email(mock_settings, mock_galaxy_settings):
     """
     Create a test client with email sending enabled.
     """
-    mock_settings.send_email = True
     # Define override
     def override_settings():
         return mock_settings