Better Bounties

[Doxxmedearly]

• rscadd: "Added new cargo bounties."
• rscadd: "Adjusted cargo bounties. Reward amounts are semi-randomized, as is the number of required items for some bounties. The types of bounties that appear are more randomized."
• tweak: "Altered some bounty descriptions."
• tweak: "Any food that has bites taken out of it will no longer count for the related bounty."
• tweak: "More types of pies, muffins, and kabobs should now count for their respective bounties."
• tweak: "Further adjusted cargo warehouse spawns."

Alright there's a bit going on here.

New bounties- self explanatory. We need more variety, especially since the PR that (rightfully) weeded out most of the meme ones. This includes wholly new bounties, new reagent types, and even a few different sections- engineering in particular was left out by bounties.

Semi-randomization: Just to add a bit of variety, there's some randomization. Reward amounts are picked from a range, so it's not always just one flat amount. If a bounty requires multiple items (ie, 6 toolboxes), there's some randomization, too. Rewards will be adjusted by this; if you need to collect more than the required_count, the reward will increase.

Also it was kind of super predictable that you'd ALWAYS have x types of bounties. I've only very slightly adjusted this to provide a bit more variety.

descriptions: self explanatory.

food bounty stuff: self explanatory. i fucking hate food typepaths.

warehouse spawns: just some further adjustments after some in-round testing. NVGs and jammers were appearing far too frequently. fire extinguishers were spammed, and I added just a bit more variety.

[Doxxmedearly]

!review

[alsoandanswer]

IMHO, prices are far too low.
For starters, an organ...
is the same price as a cup of ramen.
I suggest to keep the prices in the 1000 and above range as a benchmark.
Some of these are horrendously low - lungs...for 35 credits. Cup ramen is 20 credits.

In-game, credits are pretty much worthless, and this'll create even less incentive to actually do them.
Which is pretty bad, considering they aren't really done at all in the first place.
TL;DR - raise the prices.

Good work on increasing the variety of food items accepted though.

[Doxxmedearly]

IMHO, prices are far too low.
For starters, an organ...
is the same price as a cup of ramen.
I suggest to keep the prices in the 1000 and above range as a benchmark.
Some of these are horrendously low - lungs...for 35 credits. Cup ramen is 20 credits.

In-game, credits are pretty much worthless, and this'll create even less incentive to actually do them.
Which is pretty bad, considering they aren't really done at all in the first place.
TL;DR - raise the prices.

Good work on increasing the variety of food items accepted though.

as the new vars in the /datum/bounty state, the amounts are multiplied by 100. 25 is 2500. This is because if I just did rand(2000, 3000) we'd get very sloppy numbers like 2743. This keeps it tidy.

[mikomyazaki]

IMHO, prices are far too low.
For starters, an organ...
is the same price as a cup of ramen.
I suggest to keep the prices in the 1000 and above range as a benchmark.
Some of these are horrendously low - lungs...for 35 credits. Cup ramen is 20 credits.
In-game, credits are pretty much worthless, and this'll create even less incentive to actually do them.
Which is pretty bad, considering they aren't really done at all in the first place.
TL;DR - raise the prices.
Good work on increasing the variety of food items accepted though.

as the new vars in the /datum/bounty state, the amounts are multiplied by 100. 25 is 2500. This is because if I just did rand(2000, 3000) we'd get very sloppy numbers like 2743. This keeps it tidy.

Another way to do round numbers would be to just do... round(price, 100) and round to the nearest 100. The way you've done it works, although it's a bit less clear.

[Doxxmedearly]

IMHO, prices are far too low.
For starters, an organ...
is the same price as a cup of ramen.
I suggest to keep the prices in the 1000 and above range as a benchmark.
Some of these are horrendously low - lungs...for 35 credits. Cup ramen is 20 credits.
In-game, credits are pretty much worthless, and this'll create even less incentive to actually do them.
Which is pretty bad, considering they aren't really done at all in the first place.
TL;DR - raise the prices.
Good work on increasing the variety of food items accepted though.

as the new vars in the /datum/bounty state, the amounts are multiplied by 100. 25 is 2500. This is because if I just did rand(2000, 3000) we'd get very sloppy numbers like 2743. This keeps it tidy.

Another way to do round numbers would be to just do... round(price, 100) and round to the nearest 100. The way you've done it works, although it's a bit less clear.

Yeah i thought about that like a day after i uploaded it. Ugh.

[Doxxmedearly]

No point is leaving in confusing shitcode. Changed it to be more readable.

[Doxxmedearly]

someone kick travis please