New record consoles and removal of old datacore, adds SSrecords #4878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lohikar
reviewed
Jun 11, 2018
skull132
added
the
WIP
skull132
reviewed
Jun 16, 2018
|
Well, this is mostly waiting for #4868 to be merged to continue development. NanoUI isn't great at handling server generated assets, so this is waiting for VueUi as it has dynamic asset handling capabilities. |
# Conflicts: # code/modules/mob/living/silicon/ai/ai.dm
BotBOREALIS
added
🗺️ Mapping - Aurora
|
!review |
BotBOREALIS
removed
WIP
skull132
suggested changes
Jul 18, 2019
code/modules/modular_computers/file_system/programs/command/card.dm
Outdated
Show resolved
Hide resolved
| delete-after: True | ||
| changes: | ||
| - experiment: "Refactored record code in to record subsystem." | ||
| - rscadd: "Added new record consoles for new record code." |
There was a problem hiding this comment.
Should we note that you cannot (temporarily) print records from the console?
Co-Authored-By: Erki <skull132@users.noreply.github.com>
Co-Authored-By: Erki <skull132@users.noreply.github.com>
|
!review |
BotBOREALIS
added
Review Required
and removed
WIP
skull132
approved these changes
Jul 20, 2019
Sindorman
reviewed
Jul 25, 2019
| /datum/record/proc/Listify(var/deep = 1, var/list/excluded = list(), var/list/to_update) // Mostyl to support old things or to use with serialization | ||
| var/list/record | ||
| if(!to_update) | ||
| . = record = list() |
There was a problem hiding this comment.
Personally I nerve seen this syntax before. Confusing. I know what it does now
There was a problem hiding this comment.
This is same as:
record = list()
. = record
| // Record listener | ||
| //------------------------------- | ||
|
|
||
| /listener/record/New(datum/target) |
There was a problem hiding this comment.
This is used as general record changes listener. It's supposed to be overridden to be able to handle differently interactions for different target listeners...
Also I could have just added global methods and just called them, but I am not sure about that
Alberyk
approved these changes
Jul 27, 2019
Menown
pushed a commit
to Menown/Aurora.3
that referenced
this pull request
Jul 30, 2019
…rastation#4878) This PR is depending on Aurorastation#4868 for it's ui framework. This PR mostly makes new SSrecords subsystem responsible for storing records. This should replace old datacore. Make new SSrecords. Make things use SSrecords and whole code compile Made VueUi button <vui-button> to push parameters as JSON, preserving client side data stricture. Add new records console and admin record management. I am mostly looking for feedback regarding SSrecords and it's data storage mechanism criticism (It's using lists for storage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is depending on #4868 for it's ui framework. This PR mostly makes new
SSrecordssubsystem responsible for storing records. This should replace old datacore.<vui-button>to push parameters as JSON, preserving client side data stricture.I am mostly looking for feedback regarding SSrecords and it's data storage mechanism criticism (It's using lists for storage)