Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gadpathur Patrol Corvette Update #19933

Merged

Conversation

furrycactus
Copy link
Contributor

Largely just updates little bits on the Gadpathur Patrol Corvette to use more modern mapping standards - new airlock markers, no unsimulated shuttle floor, coloured shuttle window frames, and some redone pipes on the shuttle.

@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Sep 23, 2024
@furrycactus
Copy link
Contributor Author

!review

Copy link
Contributor

@hazelrat hazelrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
There's a space turf underneath the CO2 tank that should be plating.

I'd also recommend using space/dynamic for the EVA areas rather than open turf, being as this map is only one Z-level with nothing underneath, but this isn't an essential change. Otherwise, this all looks good to me!

@hazelrat hazelrat added the Changes Required The PR requires changes before it can be approved and/or merged. label Sep 28, 2024
@hazelrat hazelrat removed the Changes Required The PR requires changes before it can be approved and/or merged. label Sep 29, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Sep 29, 2024
Merged via the queue into Aurorastation:master with commit 527cf45 Sep 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants