Skip to content

Commit

Permalink
Fixes *some* CI issues (#11461)
Browse files Browse the repository at this point in the history
  • Loading branch information
MarinaGryphon authored Mar 17, 2021
1 parent 4cb630c commit 02e2bab
Show file tree
Hide file tree
Showing 6 changed files with 115 additions and 81 deletions.
4 changes: 2 additions & 2 deletions code/ATMOSPHERICS/components/binary_devices/passive_gate.dm
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
var/turf/T = get_turf(src)
if(!istype(T))
return
add_underlay(T, node1, turn(dir, 180), node1.icon_connect_type)
add_underlay(T, node2, dir, node2.icon_connect_type)
add_underlay(T, node1, turn(dir, 180), node1?.icon_connect_type)
add_underlay(T, node2, dir, node2?.icon_connect_type)

/obj/machinery/atmospherics/binary/passive_gate/hide(var/i)
update_underlays()
Expand Down
7 changes: 3 additions & 4 deletions code/unit_tests/recipe_tests.dm
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
/datum/unit_test/research_design_cost/start_test()
var/tested_count = 0
var/error_count = 0
for(var/T in subtypesof(/datum/design))
var/datum/design/D = new T
for(var/datum/design/D in designs)
if(ispath(D.build_path, /obj/item))
var/obj/item/I = D.Fabricate()
if(I.matter && D.materials && I.recyclable) // non-recyclable items can't be exploited
Expand Down Expand Up @@ -40,8 +39,8 @@
/datum/unit_test/stack_recipe_cost/start_test()
var/tested_count = 0
var/error_count = 0
for(var/T in subtypesof(/material))
var/material/D = new T
SSmaterials.create_material_lists() // just in case
for(var/material/D in SSmaterials.materials)
var/list/datum/stack_recipe_list/recipe_lists = D.get_recipes()
var/list/temp_matter = D.get_matter()
for(var/datum/stack_recipe_list/L in recipe_lists)
Expand Down
43 changes: 43 additions & 0 deletions html/changelogs/mdp-ci-tweaks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
################################
# Example Changelog File
#
# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
#
# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
# When it is, any changes listed below will disappear.
#
# Valid Prefixes:
# bugfix
# wip (For works in progress)
# tweak
# soundadd
# sounddel
# rscadd (general adding of nice things)
# rscdel (general deleting of nice things)
# imageadd
# imagedel
# maptweak
# spellcheck (typo fixes)
# experiment
# balance
# admin
# backend
# security
# refactor
#################################

# Your name.
author: MoondancerPony

# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again.
delete-after: True

# Any changes you've made. See valid prefix list above.
# INDENT WITH TWO SPACES. NOT TABS. SPACES.
# SCREW THIS UP AND IT WON'T WORK.
# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries.
# Please surround your changes in double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog.
changes:
- backend: "CI recipe tests no longer reinstantiate singletons."
- maptweak: "Exodus loads properly again."
- bugfix: "Fixes a runtime with atmos components."
Loading

0 comments on commit 02e2bab

Please sign in to comment.