fix(model): pass function-call service response into chat history - #43
Open
Bartok9 wants to merge 1 commit into
Open
fix(model): pass function-call service response into chat history#43Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Wire response.response_text (or error marker) into the function-role history entry instead of always storing literal "null", so the second ChatCompletion turn can condition on robot execution results. Signed-off-by: Bartok <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After a robot function-call RPC returns, ChatGPT was always appending
content: \"null\"to the function-role history entry. The second OpenAI turn therefore could not see execution results.This wires
response.response_text(bounded/coerced) into history, and stores a shorterror: …marker when the future fails.Changes
normalize_function_call_response_texthelperfunction_call_response_callbackMotivation
Function-calling feedback loop is broken without the robot response text in history, so multi-step embodied commands degrade.
Verification
All 5 tests passed offline.
AI-assisted; human-reviewed.
Claim: bartok
Operator: bartok
Campaign: aerial-drone