fix(config): whitelist AWS region and sanitize S3 bucket name - #34
Open
Bartok9 wants to merge 1 commit into
Open
fix(config): whitelist AWS region and sanitize S3 bucket name#34Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Fail-closed helpers so poisoned env cannot inject free-form region/bucket strings into AWS SDK paths. Fallback region ap-southeast-1; invalid bucket env falls back to demo auromixbucket. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds fail-closed sanitizers for AWS region (allowlist) and S3 bucket DNS rules in
UserConfig, so poisoned environment variables cannot push arbitrary region/bucket strings into AWS SDK paths used by Transcribe/Polly/S3.Changes
sanitize_aws_region— common-region allowlist; unknown values fall back toap-southeast-1sanitize_s3_bucket— DNS naming rules (length, charset, no../_)AWS_REGION/AWS_S3_BUCKETenv optional)llm_config/test/test_aws_region_bucket.py)Motivation
Dormant ROS-LLM still wires AWS IAM/S3 directly from config. Hardening config edges keeps demos safer without changing the happy path (default demo bucket retained on invalid env).
Verification
AI-assisted; human-reviewed.
Claim: bartok
Operator: bartok
Campaign: aerial-drone