Meetup: warn users about #36

lib/almanack/event_source/meetup_group.rb

@@ -2,6 +2,7 @@ module Almanack
   module EventSource
     class MeetupGroup
       def initialize(options = {})
+        warn "Meetup have disabled support for API keys. Read more at https://github.com/Aupajo/almanack/issues/36"
         @request_options = options
         @group_properties = {}
       end
@@ -108,11 +109,21 @@ def response
         data = JSON.parse(response.body)
 
         if data['problem']
-          raise MeetupAPIError, data['problem']
+          raise MeetupAPIError, error_message_from(data)
         end
 
         data
       end
+
+      def error_message_from(data)
+        message = [data['problem'], data['details']].compact.join(' - ')
+
+        if message.include?('not authorized')
+          message << ' ⚠️ See https://github.com/Aupajo/almanack/issues/36 for more details'
+        end
+
+        message
+      end
     end
   end
 end

spec/event_source/meetup_group_spec.rb

@@ -35,6 +35,19 @@ module Almanack::EventSource
           end
         end
       end
+
+      it "handles unauthorized errors" do
+        feed = MeetupGroup.new(group_urlname: 'The-Foundation-Christchurch',
+                               key: 'secrettoken',
+                               connection: Faraday.new)
+
+        VCR.use_cassette('meetup-unauthorized') do
+          from = Time.now
+          to = from + 30 * 24 * 60 * 60
+          expect { feed.events_between(from..to) }
+            .to raise_error(%r{https://github.com/Aupajo/almanack/issues/36})
+        end
+      end
     end
 
     describe "#serialized_between" do