Add analytics to Buy/Sell flow #12415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dharit-tan
reviewed
Jun 26, 2025
| import { useAppContext } from '~/context/appContext' | ||
| import { AnalyticsEvent, AllTrackingEvents } from '~/models/Analytics' | ||
|
|
||
| /** |
There was a problem hiding this comment.
idk if we need all these AI comments tbh
dharit-tan
reviewed
Jun 26, 2025
| @@ -0,0 +1,56 @@ | |||
| import { useCallback } from 'react' | |||
There was a problem hiding this comment.
wait do we really need this hook? what does this give us that the existing infrastructure doesn't?
There was a problem hiding this comment.
ah i see, to be able to use it in common?
dharit-tan
reviewed
Jun 26, 2025
| @@ -82,7 +82,7 @@ export const useBuySellSwap = (props: UseBuySellSwapProps) => { | |||
| retryTimeoutRef.current = setTimeout(() => { | |||
| invalidateBalances() | |||
| performSwap() | |||
| }, RETRY_DELAY) | |||
| }, RETRY_DELAY) as unknown as NodeJS.Timeout | |||
There was a problem hiding this comment.
yea typecheck thing
dharit-tan
approved these changes
Jun 26, 2025
audius-infra
pushed a commit
that referenced
this pull request
Jun 28, 2025
[f1cd30c] [PE-6452] Refactor web lineup tiles (#12424) Dylan Jeffers [b83ee65] Prime search results to improve autocomplete performance (#12425) Isaac Solo [c12b5d7] Add rich notifications to enable image urls (#12428) Farid Salau [fe71b33] Add analytics to Buy/Sell flow (#12415) Farid Salau [c006e1f] Move protocol dashboard to cloudflare deployment (#12420) Ray Jacobson [d1b2ba1] [HOTFIX] Fix manager mode not letting you swap from managee (#12423) JD Francis [1e34849] [PE-6454] Fix purchases after BN.js migration (#12426) Reed [6b465b8] Use prime functions for entity updates (#12421) Dylan Jeffers [c428cd2] Drop search test (#12422) Dylan Jeffers [31f5416] Fix another incorrect instance of waitForValue (#12419) JD Francis [79e3551] Fix purchase flow stuck due to waitForValue (#12418) JD Francis [1717738] [QA-2184] Fix double $ signs in purchase flow (#12417) Reed [ca3a6a2] Fix publish playlist button on missing track count (#12413) Isaac Solo [e6d86ba] Fix AudioHoverCard balance (#12416) Reed [3b2fecf] Update AudioBreakdownDrawer to use balance hooks and harmony (#12414) Reed [35a55b1] [PE-6450] Fix mobile audio balance formatting (#12412) Reed [6bc66da] Fix search lineup issues (#12411) JD Francis [bf7fa37] [QA-2168] Fix mobile-web prev/next button color (#12408) Dylan Jeffers [b9e1b25] [PE-6448] Fix mobile track tile favorites and library loading (#12409) Dylan Jeffers [d9c33bf] Fix infinite loop in mobile DMs (#12410) JD Francis [3e940b9] [PE-6418] Fix artist all hidden tracks (#12405) Dylan Jeffers [d7ffb72] Fix mobile library track tab filter display (#12402) Dylan Jeffers [11cefe8] [PE-6431] Fix extra user/handle API calls (#12406) JD Francis [2ef0a61] Adjust content padding and center align text (#12403) Isaac Solo [ec230ca] [PE-6433] Fix signed out search (#12400) Dylan Jeffers [3da884f] [PE-6441] Fix create new collection (#12404) Dylan Jeffers [e5405c6] [PE-6443] Fix collection tiles not playing in lineups (#12398) JD Francis [09a7716] [PE-6436] Fix mobile withdraw flow scrolling and validation (#12401) Reed [b351681] Add reactotron for RN network debugging (#12399) Farid Salau [7898ff7] Add retries on swaps (#12397) Farid Salau [8beb206] Fix header snapping and improve content scrolling (#12396) Isaac Solo [ea8b873] [PE-6427] Fix play bar duration (#12389) Dylan Jeffers [7de9a49] [QA-2160 PE-6438] Fix Android icon colors (#12390) Dylan Jeffers [2e5d6e5] [PE-6432] Reduce mobile web explore page tiles (#12393) Dylan Jeffers [ed89aa8] [PE-6435] Fix selectable pill isSelected color (#12392) Dylan Jeffers [c30350e] [QA-2167] Hide empty track page lineup for artists with one track (#12395) KJ [590ccea] [QA-1625] Contain scroll in playlist tiles (#12394) KJ [cc42ce5] [PE-6428] Fix_confetti_final_final_final_v2 (#12387) JD Francis [8ef4ca4] [PE-6419|PE-6434] Fix flash of sign up on mobile apps due to default account status (#12384) JD Francis [d5ba7b9] [PE-6383] Fix ATA of ATA bug in withdraw flow (#12382) Reed [1026ce1] Remove BN.js from web/mobile/common/embed/fixed-decimal (#12368) Reed [a539209] Optimize search and explore performance + animation (#12375) Isaac Solo [443937c] [PE-6403] Fix mobile library radio buttons not working (#12349) JD Francis [799cb55] [QA-2161] Fix mobile favorited album/playlist search (#12374) Dylan Jeffers [d9bb313] [QA-2165] Fix profile nav item navigation (#12376) Dylan Jeffers [bba94bd] [QA-2166] Fix broken mobile playback (#12377) Dylan Jeffers [86c5fbf] Refactor TrendingPageProvider to funcitonal component (#12378) Farid Salau [8b7db22] [QA-1985] Remove multiselect prop to fix upload tag delete on click functionality (#12379) KJ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new analytics tracking for the buy and sell flows within the application. It leverages a new
useBuySellAnalyticshook to provide consistent and type-safe event tracking for various stages of the swap process.Changes:
New Analytics Hooks:
useAnalytics.ts: A core analytics hook providing a consistent interface for tracking events.useBuySellAnalytics.ts: A specialized hook for buy-sell swap flows, with pre-configured methods for events liketrackSwapRequested,trackSwapConfirmed,trackSwapSuccess,trackSwapFailure, andtrackAddFundsClicked.Analytics Event Definitions:
Nameenums and corresponding types (BuySellSwapEventFields,BuySellSwapRequested,BuySellSwapConfirmed,BuySellSwapSuccess,BuySellSwapFailure,BuySellAddFundsClicked) inpackages/common/src/models/Analytics.tsto support the new buy/sell analytics events.Integration into Buy/Sell Flow:
packages/mobile/src/screens/buy-sell-screen/BuySellFlow.tsxto utilize theuseBuySellAnalyticshook for trackingtrackSwapRequestedandtrackAddFundsClickedevents.makeandtrackcalls inBuySellFlow.tsxin favor of the new specialized hook.Store Updates:
packages/common/src/store/ui/buy-sell/types.tsto includeConfirmationScreenDataandexchangeRateinSuccessDisplayData, andsignatureinSwapResult. Also addedgetSwapTokensutility.packages/common/src/store/ui/buy-sell/useBuySellSwap.tsto passsignatureintrackSwapSuccess.packages/common/src/store/ui/buy-sell/useSwapDisplayData.tsandpackages/common/src/store/ui/buy-sell/useTokenSwapForm.tsto handleexchangeRatemore consistently.These changes ensure that all critical actions within the buy and sell flows are properly instrumented for analytics, providing better insights into user behavior.