Skip to content

Conversation

@rickyrombo
Copy link
Contributor

For adding, removing, and reordering tracks in a playlist, first get fresh data.

  • On add/remove, continue the operation
  • On reorder, fail with a toast and let the user try again with the fresh state

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

⚠️ No Changeset found

Latest commit: 87c5fc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice improvement

freshPlaylist?.playlist_contents.track_ids.map(({ track }) => track) ?? []

// If the lengths don't match or tracks are in a different order, the collection is stale
const isStale =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't other criteria like description edit also make it stale?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but that won't conflict with a reorder

@rickyrombo rickyrombo merged commit 03dfcc6 into main Feb 10, 2026
12 checks passed
@rickyrombo rickyrombo deleted the mjp-playlist-stomping branch February 10, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants