Skip to content

Don't show PlayBarChin in mobile remix parent lineup #11997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2025
Merged

Don't show PlayBarChin in mobile remix parent lineup #11997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cb591c
Don't show PlayBarChin in mobile remix parent lineup
dharit-tan Apr 30, 2025
78024a4
asdf
dharit-tan Apr 30, 2025
ab92c83
hide instead of show
dharit-tan Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/mobile/src/components/core/SectionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,18 +125,20 @@ export const SectionList = forwardRef(function SectionList<
ItemT,
SectionT = DefaultSectionT
>(
props: Animated.AnimatedProps<RNSectionListProps<ItemT, SectionT>>,
props: Animated.AnimatedProps<RNSectionListProps<ItemT, SectionT>> & {
hidePlayBarChin?: boolean
},
ref: Ref<RNSectionList<ItemT, SectionT>>
) {
const { ListFooterComponent, ...other } = props
const { ListFooterComponent, hidePlayBarChin, ...other } = props

const FooterComponent = ListFooterComponent ? (
<>
{ListFooterComponent}
<PlayBarChin />
{hidePlayBarChin ? null : <PlayBarChin />}
</>
) : (
PlayBarChin
) : hidePlayBarChin ? null : (
<PlayBarChin />
)

const sectionListProps = {
Expand Down
7 changes: 7 additions & 0 deletions packages/mobile/src/components/lineup/TanQueryLineup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ export type LineupProps = {
*/
itemStyles?: ViewStyle

/**
* Whether to show the play bar chin
*/
hidePlayBarChin?: boolean

// Tan query props
pageSize: number
initialPageSize?: number
Expand Down Expand Up @@ -350,6 +355,7 @@ export const TanQueryLineup = ({
isPending,
queryData = [],
maxEntries = Infinity,
hidePlayBarChin = false,
...listProps
}: LineupProps) => {
const debouncedLoadNextPage = useDebouncedCallback(
Expand Down Expand Up @@ -520,6 +526,7 @@ export const TanQueryLineup = ({
onScroll={handleScroll}
ListHeaderComponent={hideHeaderOnEmpty && isEmpty ? undefined : header}
ListFooterComponent={lineup.hasMore ? null : ListFooterComponent}
hidePlayBarChin={true}
ListEmptyComponent={LineupEmptyComponent}
onEndReached={handleEndReached}
onEndReachedThreshold={LOAD_MORE_THRESHOLD}
Expand Down
1 change: 1 addition & 0 deletions packages/mobile/src/screens/track-screen/TrackScreenLineup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export const TrackScreenLineup = ({
hasMore={false}
isPending={isPending}
queryData={data}
hidePlayBarChin={true}
/>
{parentTrackId ? (
<ViewOtherRemixesButton parentTrackId={parentTrackId} />
Expand Down