Skip to content

[PE-6071] Overflow: hidden on remix contest info section #11961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

[PE-6071] Overflow: hidden on remix contest info section #11961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f935a73
[PE-6071] Overflow: hidden on remix contest info section
dharit-tan Apr 28, 2025
f6da563
motion
dharit-tan Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/web/src/pages/track-page/components/desktop/RemixContestDetailsTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,7 @@ export const RemixContestDetailsTab = ({
const isContestEnded = dayjs(remixContest?.endDate).isBefore(dayjs())

return (
<Flex
column
gap='l'
p='xl'
css={{
transition: 'height var(--harmony-expressive)'
}}
>
<Flex column gap='l' p='xl'>
<Flex row gap='s'>
<Text variant='title' size='m' color='accent'>
{messages.due}
Expand Down
21 changes: 5 additions & 16 deletions packages/web/src/pages/track-page/components/desktop/RemixContestSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
Flex,
IconCloudUpload,
IconTrophy,
motion,
spacing,
Text
} from '@audius/harmony'
Expand Down Expand Up @@ -107,13 +108,7 @@ export const RemixContestSection = ({
const totalBoxHeight = TAB_BAR_HEIGHT + contentHeight

return (
<Flex
column
gap='l'
css={{
transition: 'height var(--harmony-expressive)'
}}
>
<Flex column gap='l'>
<Flex alignItems='center' gap='s'>
<IconTrophy color='default' />
<Text variant='title' size='l'>
Expand All @@ -125,7 +120,8 @@ export const RemixContestSection = ({
shadow='mid'
borderRadius='l'
css={{
transition: 'height var(--harmony-expressive)',
transition: motion.quick,
overflow: 'hidden',
height: totalBoxHeight
}}
>
Expand All @@ -147,14 +143,7 @@ export const RemixContestSection = ({
<Flex h={spacing.m + spacing['2xl']} />
)}
</Flex>
<Box
css={{
transition: 'height var(--harmony-expressive)',
height: contentHeight
}}
>
{ContentBody}
</Box>
{ContentBody}
</Flex>
</Box>
</Flex>
Expand Down